Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-18 Thread Frediano Ziglio
> > On Mon, 2016-10-17 at 06:55 -0400, Frediano Ziglio wrote: > > >  > > > > I just realized that beside spice_assert replacement this test is > > different. > > Not seamless is the old "seamless && success" condition so this is > > equivalent > > Oh, good catch. > > > to > > > > g_warn_if_fai

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-18 Thread Jonathon Jongsma
On Mon, 2016-10-17 at 06:55 -0400, Frediano Ziglio wrote: > >  > > I just realized that beside spice_assert replacement this test is > different. > Not seamless is the old "seamless && success" condition so this is > equivalent Oh, good catch. > to  > > g_warn_if_fail(!(seamless && success) ||

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-18 Thread Jonathon Jongsma
On Fri, 2016-10-14 at 10:49 -0400, Frediano Ziglio wrote: > > > > From: Jonathon Jongsma > > > > Encapsulate MainChannel a bit better in preparation for proting to > > GObject. > > Small typo > proting -> porting > right > > > >  > > diff --git a/server/main-channel.h b/server/main-channel.

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-17 Thread Frediano Ziglio
> > From: Jonathon Jongsma > > Encapsulate MainChannel a bit better in preparation for proting to > GObject. > --- > server/main-channel-client.c | 24 +++- > server/main-channel.c| 15 +++ > server/main-channel.h| 2 ++ > 3 files changed, 28 ins

Re: [Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-14 Thread Frediano Ziglio
> From: Jonathon Jongsma > > Encapsulate MainChannel a bit better in preparation for proting to > GObject. Small typo proting -> porting > --- > server/main-channel-client.c | 24 +++- > server/main-channel.c| 15 +++ > server/main-channel.h| 2

[Spice-devel] [PATCH spice-server v3 2/3] Improve MainChannel encapsulation

2016-10-14 Thread Frediano Ziglio
From: Jonathon Jongsma Encapsulate MainChannel a bit better in preparation for proting to GObject. --- server/main-channel-client.c | 24 +++- server/main-channel.c| 15 +++ server/main-channel.h| 2 ++ 3 files changed, 28 insertions(+), 13 deleti