Re: [Spice-devel] [PATCH spice-xpi 2/4] build: use spice-protocol as a submodule

2012-02-24 Thread Daniel P. Berrange
On Fri, Feb 24, 2012 at 01:46:13PM +0200, Alon Levy wrote: > On Fri, Feb 24, 2012 at 06:08:38AM -0500, Marc-André Lureau wrote: > > Hi > > > > - Mensaje original - > > > On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote: > > > > > > Is it just me or does this patch do way m

Re: [Spice-devel] [PATCH spice-xpi 2/4] build: use spice-protocol as a submodule

2012-02-24 Thread Alon Levy
On Fri, Feb 24, 2012 at 06:08:38AM -0500, Marc-André Lureau wrote: > Hi > > - Mensaje original - > > On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote: > > > > Is it just me or does this patch do way more then the subject says? I > > don't feel I can review it the way it is

Re: [Spice-devel] [PATCH spice-xpi 2/4] build: use spice-protocol as a submodule

2012-02-24 Thread Marc-André Lureau
Hi - Mensaje original - > On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote: > > Is it just me or does this patch do way more then the subject says? I > don't feel I can review it the way it is. I cleans up a bit the build-sys I thought there was no need for seperate pat

Re: [Spice-devel] [PATCH spice-xpi 2/4] build: use spice-protocol as a submodule

2012-02-24 Thread Alon Levy
On Fri, Feb 24, 2012 at 11:54:36AM +0100, Marc-André Lureau wrote: Is it just me or does this patch do way more then the subject says? I don't feel I can review it the way it is. > --- > .gitmodules |3 + > Makefile.am |4 +- > SpiceXPI/Makefile.am

[Spice-devel] [PATCH spice-xpi 2/4] build: use spice-protocol as a submodule

2012-02-24 Thread Marc-André Lureau
--- .gitmodules |3 + Makefile.am |4 +- SpiceXPI/Makefile.am| 17 +++ SpiceXPI/src/plugin/Makefile.am | 102 ++ autogen.sh |3 + configure.ac| 21 +