Re: [Spice-devel] [PATCH spice 1/3] Use the spice-common submodule

2012-03-25 Thread Alon Levy
On Sun, Mar 25, 2012 at 05:11:33PM +0200, Marc-André Lureau wrote: > This patch will replace the common/ directory with the spice-common > project. It is for now a simple project subdirectory shared with > spice-gtk, but the goal is to make it a proper library later on. > > With this change, the s

Re: [Spice-devel] [PATCH spice 1/3] Use the spice-common submodule

2012-03-25 Thread Marc-André Lureau
On Sun, Mar 25, 2012 at 5:26 PM, Alon Levy wrote: > tarball is not an option IMO. We want windows development to be as easy > as linux development, and that means git. But what's the problem? it > will work just the same, vcproj changes etc. That was a suggestion. Imho, we should even go further

Re: [Spice-devel] [PATCH spice 1/3] Use the spice-common submodule

2012-03-25 Thread Alon Levy
On Sun, Mar 25, 2012 at 05:51:56PM +0200, Marc-André Lureau wrote: > On Sun, Mar 25, 2012 at 5:26 PM, Alon Levy wrote: > > tarball is not an option IMO. We want windows development to be as easy > > as linux development, and that means git. But what's the problem? it > > will work just the same, v

Re: [Spice-devel] [PATCH spice 1/3] Use the spice-common submodule

2012-03-25 Thread Alon Levy
On Sun, Mar 25, 2012 at 05:11:33PM +0200, Marc-André Lureau wrote: > This patch will replace the common/ directory with the spice-common > project. It is for now a simple project subdirectory shared with > spice-gtk, but the goal is to make it a proper library later on. > > With this change, the s

Re: [Spice-devel] [PATCH spice 1/3] Use the spice-common submodule

2012-03-25 Thread Marc-André Lureau
On Sun, Mar 25, 2012 at 6:42 PM, Alon Levy wrote: > Other then that, and with a suitable Visual Studio fix, ACK. What do you mean by Visual Studio fix? I said I left that part out intentionally. It's already quite some work to deal with one (that is more capable anyway). -- Marc-André Lureau __

Re: [Spice-devel] [PATCH spice 1/3] Use the spice-common submodule

2012-03-25 Thread Alon Levy
On Sun, Mar 25, 2012 at 06:46:56PM +0200, Marc-André Lureau wrote: > On Sun, Mar 25, 2012 at 6:42 PM, Alon Levy wrote: > > Other then that, and with a suitable Visual Studio fix, ACK. > > What do you mean by Visual Studio fix? I said I left that part out > intentionally. It's already quite some w