Re: [Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-14 Thread Christophe Fergeau
On Mon, Sep 12, 2016 at 08:38:32AM -0400, Frediano Ziglio wrote: > Don't we have an enum for this return instead of using int ? > > enum { > AGENT_MSG_FILTER_OK, > AGENT_MSG_FILTER_DISCARD, > AGENT_MSG_FILTER_PROTO_ERROR, > AGENT_MSG_FILTER_MONITORS_CONFIG, > AGENT_MSG_FILTER_E

Re: [Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-12 Thread Pavel Grunt
On Mon, 2016-09-12 at 08:38 -0400, Frediano Ziglio wrote: > I think the rationale of this is to remove the error return > parameter and > make vdi_port_read_buf_process easier/shorter. Yes, also I have some patches which will make use of the return value > > > > > --- > >  server/reds.c | 55

Re: [Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-12 Thread Frediano Ziglio
I think the rationale of this is to remove the error return parameter and make vdi_port_read_buf_process easier/shorter. > > --- > server/reds.c | 55 --- > 1 file changed, 20 insertions(+), 35 deletions(-) > > diff --git a/server/reds.c b/ser

[Spice-devel] [PATCH spice 2/2] reds: Refactor agent message forwarding

2016-09-12 Thread Pavel Grunt
--- server/reds.c | 55 --- 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/server/reds.c b/server/reds.c index 800107b..a13a14a 100644 --- a/server/reds.c +++ b/server/reds.c @@ -763,34 +763,18 @@ static void vdi_port_read_buf_re