[Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

2016-09-07 Thread Jonathon Jongsma
--- Changes in v2: - added generated files to .gitignore .gitignore | 2 ++ server/Makefile.am | 31 +++ 2 files changed, 33 insertions(+) diff --git a/.gitignore b/.gitignore index 90fb62a..2df7c3f 100644 --- a/.gitignore +++ b/.gitignore @@ -33,3 +33,5 @@

Re: [Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

2016-09-08 Thread Christophe Fergeau
Looked at this a bit closer, any reason why this is limited to spice-server.h and not including the other public headers? I don't really understand why we need these enums at this point. Also, some of the enums in spice-server.h are not taken into account because they are not of the form typedef en

Re: [Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

2016-09-08 Thread Frediano Ziglio
> > Looked at this a bit closer, any reason why this is limited to > spice-server.h and not including the other public headers? I don't > really understand why we need these enums at this point. > Also, some of the enums in spice-server.h are not taken into account > because they are not of the fo

Re: [Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

2016-09-08 Thread Jonathon Jongsma
On Thu, 2016-09-08 at 08:25 -0400, Frediano Ziglio wrote: > > > > > > Looked at this a bit closer, any reason why this is limited to > > spice-server.h and not including the other public headers? I don't > > really understand why we need these enums at this point. > > Also, some of the enums in s

Re: [Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

2016-09-09 Thread Christophe Fergeau
On Thu, Sep 08, 2016 at 09:09:53AM -0500, Jonathon Jongsma wrote: > On Thu, 2016-09-08 at 08:25 -0400, Frediano Ziglio wrote: > > > > > > > > > Looked at this a bit closer, any reason why this is limited to > > > spice-server.h and not including the other public headers? I don't > > > really unde

Re: [Spice-devel] [PATCH v2 03/10] Generate GTypes for spice-server enums

2016-09-09 Thread Jonathon Jongsma
On Fri, 2016-09-09 at 11:18 +0200, Christophe Fergeau wrote: > On Thu, Sep 08, 2016 at 09:09:53AM -0500, Jonathon Jongsma wrote: > > > > On Thu, 2016-09-08 at 08:25 -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > > > > Looked at this a bit closer, any reason why this is limited t