Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-11 Thread Alon Levy
On Sun, Jul 10, 2011 at 09:55:21AM +0300, Yonit Halperin wrote: On 07/07/2011 07:33 PM, Alon Levy wrote: used to move dirty rectangle notification from update_area to surface_updated. This is RfC quality. Specifically where to call surface_updated. Currently I only call it from stop. This

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-11 Thread Alon Levy
On Mon, Jul 11, 2011 at 01:48:38PM +0300, Alon Levy wrote: On Sun, Jul 10, 2011 at 09:55:21AM +0300, Yonit Halperin wrote: On 07/07/2011 07:33 PM, Alon Levy wrote: used to move dirty rectangle notification from update_area to surface_updated. This is RfC quality. Specifically where to

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-10 Thread Yonit Halperin
On 07/07/2011 07:33 PM, Alon Levy wrote: used to move dirty rectangle notification from update_area to surface_updated. This is RfC quality. Specifically where to call surface_updated. Currently I only call it from stop. This should be good enough for migration, which is the only use case I

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-08 Thread Gerd Hoffmann
On 07/07/11 18:33, Alon Levy wrote: This is RfC quality. Specifically where to call surface_updated. Currently I only call it from stop. This should be good enough for migration, which is the only use case I think. This means after stop qemu is guranteed to know the dirty regions of all

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-08 Thread Alon Levy
On Fri, Jul 08, 2011 at 08:41:22AM +0200, Gerd Hoffmann wrote: On 07/07/11 18:33, Alon Levy wrote: This is RfC quality. Specifically where to call surface_updated. Currently I only call it from stop. This should be good enough for migration, which is the only use case I think. This means after

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-08 Thread Gerd Hoffmann
On 07/08/11 09:47, Alon Levy wrote: On Fri, Jul 08, 2011 at 08:41:22AM +0200, Gerd Hoffmann wrote: On 07/07/11 18:33, Alon Levy wrote: This is RfC quality. Specifically where to call surface_updated. Currently I only call it from stop. This should be good enough for migration, which is the

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-08 Thread Alon Levy
On Fri, Jul 08, 2011 at 10:05:19AM +0200, Gerd Hoffmann wrote: On 07/08/11 09:47, Alon Levy wrote: On Fri, Jul 08, 2011 at 08:41:22AM +0200, Gerd Hoffmann wrote: On 07/07/11 18:33, Alon Levy wrote: This is RfC quality. Specifically where to call surface_updated. Currently I only call it

Re: [Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-08 Thread Gerd Hoffmann
BTW: wasn't the plan to remove the rect args from update_area_async? I thought the idea was just to remove the dirty rects, not the actual rect the guest wants updated. This patch removes the former. Ah, ok. Yes, plan was to zap just the dirty rects. cheers, Gerd

[Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

2011-07-07 Thread Alon Levy
used to move dirty rectangle notification from update_area to surface_updated. This is RfC quality. Specifically where to call surface_updated. Currently I only call it from stop. This should be good enough for migration, which is the only use case I think. This means after stop qemu is guranteed