Re: [Spice-devel] [PATCH v3 1/2] Do endian swapping.

2017-01-13 Thread Michal Suchánek
On Fri, 13 Jan 2017 06:52:17 -0500 (EST) Frediano Ziglio wrote: > > case VD_AGENT_FILE_XFER_STATUS: > > case VD_AGENT_FILE_XFER_DATA: > > +if (message_header->size < > > sizeof(VDAgentFileXferStartMessage)) > > +goto size_error; > > +*id = GUINT32_FROM_LE(*id

Re: [Spice-devel] [PATCH v3 1/2] Do endian swapping.

2017-01-13 Thread Frediano Ziglio
> > This allows running big endian and little endian guest side by side using > cut & paste between them. > > There is a general design idea that swapping should come as close to > virtio_read/virtio_write as possible. In particular, the protocol > between vdagent and vdagentd is guest-specific an

Re: [Spice-devel] [PATCH v3 1/2] Do endian swapping.

2017-01-12 Thread Michal Suchánek
Hello, On Wed, 11 Jan 2017 17:04:10 +0100 Victor Toso wrote: > Hi, > > Sorry for taking some time to reply back. > > On Mon, Jan 09, 2017 at 01:54:30PM +0100, Michal Suchanek wrote: > > This allows running big endian and little endian guest side by side > > using cut & paste between them. > >

Re: [Spice-devel] [PATCH v3 1/2] Do endian swapping.

2017-01-11 Thread Victor Toso
Hi, Sorry for taking some time to reply back. On Mon, Jan 09, 2017 at 01:54:30PM +0100, Michal Suchanek wrote: > This allows running big endian and little endian guest side by side > using cut & paste between them. > > There is a general design idea that swapping should come as close to > virtio_

[Spice-devel] [PATCH v3 1/2] Do endian swapping.

2017-01-09 Thread Michal Suchanek
This allows running big endian and little endian guest side by side using cut & paste between them. There is a general design idea that swapping should come as close to virtio_read/virtio_write as possible. In particular, the protocol between vdagent and vdagentd is guest-specific and in native en