>
> I've been trying to review this for quite a while now. It's rather
> dense and difficult to make sure I understand all of the potential
> minor changes, etc.
>
> In general, it looks good, but I have a couple of questions/comments
> below.
>
> On Tue, 2016-12-20 at 17:44 +, Frediano Zigl
I've been trying to review this for quite a while now. It's rather
dense and difficult to make sure I understand all of the potential
minor changes, etc.
In general, it looks good, but I have a couple of questions/comments
below.
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> This pa
This patch is quite huge but have some benefits:
- reduce dependency (DummyChannel* and some RedChannelClient internals);
- reuse RedChannelClient instead of reading from the RedsStream
directly.
You can see that SndChannelClient has much less field
as the code to read/write from/to client is re
