Re: [Spice-devel] [PATCH xf86-video-qxl] Correct a long standing led state bug in XSpice.

2019-04-05 Thread Jeremy White
Signed-off-by: Jeremy White Acked-by: Victor Toso I don't have commit access there, do you? If not, you can submit a merge request and ask people to merge. Thanks for the review, and no, it looks like I don't. I've submitted a merge request, at least as far as I can tell... Cheers,

Re: [Spice-devel] [PATCH xf86-video-qxl] Correct a long standing led state bug in XSpice.

2019-04-05 Thread Victor Toso
Hi, On Fri, Apr 05, 2019 at 09:38:31AM -0500, Jeremy White wrote: > The CtrlProc for our keyboard driver incorrectly mapped > the device private to a SpiceKbd* intead of to a InputInfoPtr. > > That resulted in led state being written into the driver name > for our driver structure, instead of

[Spice-devel] [PATCH xf86-video-qxl] Correct a long standing led state bug in XSpice.

2019-04-05 Thread Jeremy White
The CtrlProc for our keyboard driver incorrectly mapped the device private to a SpiceKbd* intead of to a InputInfoPtr. That resulted in led state being written into the driver name for our driver structure, instead of into the led state. That, in turn, led to a cool bug where if you pressed caps