Re: [Spice-devel] [client v3 1/6] channel-display: Minimize the stream lag by ignoring the server one

2019-06-28 Thread Kevin Pouget
Hello, I looked at the patch series and tried to describe its modifications to better understand it; you'll find below my comments. François, in the middle of it you'll find a few nit suggestions to improve the readability. the patch for display_handle_stream_data() is obviously the most complex,

[Spice-devel] [client v3 1/6] channel-display: Minimize the stream lag by ignoring the server one

2019-06-25 Thread Francois Gouget
The client is in a better position than the server to pick the minimum lag needed to compensate for frame arrival time jitter and ensure smooth video playback. To do so: - It ignores the lag specified by the server through the mmtime clock adjustments (but this lag is still tracked for the stream