Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-07 Thread Victor Toso
Hi, On Thu, Jan 03, 2019 at 09:57:40AM +0100, Jakub Janku wrote: > Hi, > > > On Wed, Jan 2, 2019, 5:31 PM Victor Toso > > Hi, > > > > Thanks for taking a look! > > > > On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote: > > > Hi, > > > > > > On Wed, Dec 19, 2018 at 3:30 PM Victor

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-03 Thread Jakub Janku
Hi, On Wed, Jan 2, 2019, 5:31 PM Victor Toso Hi, > > Thanks for taking a look! > > On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote: > > Hi, > > > > On Wed, Dec 19, 2018 at 3:30 PM Victor Toso > wrote: > > > > > > From: Victor Toso > > > > > > If SpiceGtkSession is holding the

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-02 Thread Victor Toso
Hi, Thanks for taking a look! On Sun, Dec 30, 2018 at 10:23:02PM +0100, Jakub Janku wrote: > Hi, > > On Wed, Dec 19, 2018 at 3:30 PM Victor Toso wrote: > > > > From: Victor Toso > > > > If SpiceGtkSession is holding the keyboard, that's huge indication > > that we should not be requesting

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-30 Thread Jakub Janku
Hi, On Wed, Dec 19, 2018 at 3:30 PM Victor Toso wrote: > > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that we should not be requesting clipboard data yet. The proper time > to request it is when another application in the client machine is >

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-21 Thread Christophe Fergeau
On Thu, Dec 20, 2018 at 04:41:48PM -0500, james harvey wrote: > On Thu, Dec 20, 2018 at 12:36 PM Christophe Fergeau > wrote: > > Hey, > > > > With this patch applied, I cannot seem to be able to copy from client to > > guest when using wayland. > > > > Christophe > > I admit I only have a vague

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-21 Thread Victor Toso
Hi, On Thu, Dec 20, 2018 at 06:36:02PM +0100, Christophe Fergeau wrote: > Hey, > > With this patch applied, I cannot seem to be able to copy from client to > guest when using wayland. > > Christophe You are right... I thought I had tested it properly... > On Wed, Dec 19, 2018 at 03:29:44PM

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-20 Thread james harvey
On Thu, Dec 20, 2018 at 12:36 PM Christophe Fergeau wrote: > Hey, > > With this patch applied, I cannot seem to be able to copy from client to > guest when using wayland. > > Christophe I admit I only have a vague understanding of what Wayland is. I'm using Xorg & Plasma on Arch Linux. Some

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-20 Thread Christophe Fergeau
Hey, With this patch applied, I cannot seem to be able to copy from client to guest when using wayland. Christophe On Wed, Dec 19, 2018 at 03:29:44PM +0100, Victor Toso wrote: > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that we should not be

Re: [Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-19 Thread Victor Toso
Hi, On Wed, Dec 19, 2018 at 03:29:44PM +0100, Victor Toso wrote: > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that we should not be requesting clipboard data yet. The proper time > to request it is when another application in the client machine is

[Spice-devel] [spice-gtk] gtk-session: do not request guest's clipboard data unnecessarily

2018-12-19 Thread Victor Toso
From: Victor Toso If SpiceGtkSession is holding the keyboard, that's huge indication that we should not be requesting clipboard data yet. The proper time to request it is when another application in the client machine is asking for it, which means the user would switch to another application to