Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

2016-03-22 Thread Fabiano Fidêncio
On Tue, Mar 22, 2016 at 1:43 PM, Victor Toso wrote: > Interesting that I don't get the crash with remote-viewer, probably > because the shared-folder is not started by default as it is with spicy. > I thought it would be interesting to add here. > > Acked-by: Victor Toso Pushed, thanks! > > On

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

2016-03-22 Thread Victor Toso
Interesting that I don't get the crash with remote-viewer, probably because the shared-folder is not started by default as it is with spicy. I thought it would be interesting to add here. Acked-by: Victor Toso On Tue, Mar 22, 2016 at 01:01:30PM +0100, Pavel Grunt wrote: > Ack.  > > Pavel > > On

Re: [Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

2016-03-22 Thread Pavel Grunt
Ack.  Pavel On Mon, 2016-03-21 at 16:02 +0100, Fabiano Fidêncio wrote: > Don't try to get the cancellable from a task that is, for sure > (ensured > by us), NULL. See the backtrace: > >  #0  0x729cf250 in g_task_get_cancellable () at > /lib64/libgio-2.0.so.0 >  #1  0x778a9012 in

[Spice-devel] [spice-gtk] vmcstream, gtask: Fix crash when trying to use webdav

2016-03-21 Thread Fabiano Fidêncio
Don't try to get the cancellable from a task that is, for sure (ensured by us), NULL. See the backtrace: #0 0x729cf250 in g_task_get_cancellable () at /lib64/libgio-2.0.so.0 #1 0x778a9012 in spice_vmc_input_stream_read_all_async (stream=, buffer=0x7070f8, count=8, io_priority=