[Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-07 Thread Victor Toso
From: Victor Toso If SpiceGtkSession is holding the keyboard, that's huge indication that the client should not be requesting guest's clipboard data yet. This patch adds a check in clipboard_get() callback, to avoid such requests. In Linux, this only happens with X11 backend. This patch helps t

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-07 Thread Jakub Janku
Hi, On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that the client should not be requesting guest's clipboard data yet. > > This patch adds a check in clipboard_get() callback, to avoid such > reque

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-08 Thread Victor Toso
Hi, Thanks for review! On Mon, Jan 07, 2019 at 09:28:04PM +0100, Jakub Janku wrote: > Hi, > > On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > > > From: Victor Toso > > > > If SpiceGtkSession is holding the keyboard, that's huge indication > > that the client should not be requesting gues

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-08 Thread Jakub Janku
On Tue, Jan 8, 2019 at 10:06 AM Victor Toso wrote: > > Hi, > > Thanks for review! > > On Mon, Jan 07, 2019 at 09:28:04PM +0100, Jakub Janku wrote: > > Hi, > > > > On Mon, Jan 7, 2019 at 1:41 PM Victor Toso wrote: > > > > > > From: Victor Toso > > > > > > If SpiceGtkSession is holding the keyboar

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-08 Thread james harvey
On Mon, Jan 7, 2019 at 7:41 AM Victor Toso wrote: > > From: Victor Toso > > If SpiceGtkSession is holding the keyboard, that's huge indication > that the client should not be requesting guest's clipboard data yet. > > This patch adds a check in clipboard_get() callback, to avoid such > requests.

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-09 Thread james harvey
On Tue, Jan 8, 2019 at 11:13 PM james harvey wrote: > v1 of your patch works extremely well for me. I've been running it > since Dec 14. I'm about to start using the .patch files you emailed today, but giving a few follow-ups first, still regarding v1. > If I have a single spice client open, it

Re: [Spice-devel] [spice-gtk v2] gtk-session: do not request guest's clipboard data unnecessarily

2019-01-10 Thread Victor Toso
Hi, Only replying to the crash bit for now ;) On Wed, Jan 09, 2019 at 06:29:51PM -0500, james harvey wrote: > > Please let me know if it looks like this crash is related to > > the clipboard problems, or if I should create a bug report on > > it. My best guess is it's related to the clipboard pr