Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 11:52:31AM +0200, Pavel Grunt wrote: > On Fri, 2016-05-27 at 11:45 +0200, Victor Toso wrote: > > Hi, > > > > On Fri, May 27, 2016 at 11:37:17AM +0200, Pavel Grunt wrote: > > > Hi, > > > > > > Can you explain when this can happen? Is it related to your tests? > > > >

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Pavel Grunt
On Fri, 2016-05-27 at 11:45 +0200, Victor Toso wrote: > Hi, > > On Fri, May 27, 2016 at 11:37:17AM +0200, Pavel Grunt wrote: > > Hi, > > > > Can you explain when this can happen? Is it related to your tests? > > 100% related to tests. I'm testing file-transfer without > SpiceMainChannel set. Ar

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Victor Toso
Hi, On Fri, May 27, 2016 at 11:37:17AM +0200, Pavel Grunt wrote: > Hi, > > Can you explain when this can happen? Is it related to your tests? 100% related to tests. I'm testing file-transfer without SpiceMainChannel set. > > On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > > --- > >  src/

Re: [Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-27 Thread Pavel Grunt
Hi, Can you explain when this can happen? Is it related to your tests? On Mon, 2016-05-23 at 13:50 +0200, Victor Toso wrote: > --- >  src/spice-channel.c | 5 - >  1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/spice-channel.c b/src/spice-channel.c > index c555f75..8b159f

[Spice-devel] [spice-gtk v2 13/16] channel: avoid crash on spice_channel_wakupe due NULL channel

2016-05-23 Thread Victor Toso
--- src/spice-channel.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/spice-channel.c b/src/spice-channel.c index c555f75..8b159f4 100644 --- a/src/spice-channel.c +++ b/src/spice-channel.c @@ -1891,7 +1891,10 @@ error: G_GNUC_INTERNAL void spice_channel_wakeup(Spic