Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-14 Thread Frediano Ziglio
> Hi, > > On Wed, Dec 12, 2018 at 06:43:04AM -0500, Frediano Ziglio wrote: > > > Documentation saying that this feature rely on agent seems to be > > > lacking. e.g: grep for 'agent' on SpiceGtkSession > > > > > > > As spice-gtk is a public library with an API speaking of "Spice > > > > client" i

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-12 Thread Victor Toso
Hi, On Wed, Dec 12, 2018 at 06:43:04AM -0500, Frediano Ziglio wrote: > > Documentation saying that this feature rely on agent seems to be > > lacking. e.g: grep for 'agent' on SpiceGtkSession > > > > > As spice-gtk is a public library with an API speaking of "Spice > > > client" is not a good thi

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-12 Thread Frediano Ziglio
> Hi, > > On Mon, Dec 10, 2018 at 08:39:46AM -0500, Frediano Ziglio wrote: > > > On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > > > > > > > From: Victor Toso > > > > > > > > > > Spice client should listen to SpiceMainChannel::agent-connected > > > > > notification and

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-11 Thread Victor Toso
Hi, On Mon, Dec 10, 2018 at 08:39:46AM -0500, Frediano Ziglio wrote: > > On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > > > > > From: Victor Toso > > > > > > > > Spice client should listen to SpiceMainChannel::agent-connected > > > > notification and avoid calling any

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Frediano Ziglio
> On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > Spice client should listen to SpiceMainChannel::agent-connected > > > notification and avoid calling any clipboard related functions such as > > > spice_gtk_session_paste_from_guest() fro

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Victor Toso
On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Spice client should listen to SpiceMainChannel::agent-connected > > notification and avoid calling any clipboard related functions such as > > spice_gtk_session_paste_from_guest() from client-gtk l

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Frediano Ziglio
> > From: Victor Toso > > Spice client should listen to SpiceMainChannel::agent-connected > notification and avoid calling any clipboard related functions such as > spice_gtk_session_paste_from_guest() from client-gtk library. > > This patch removes the silent return of agent_clipboard_grab() i

[Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-10 Thread Victor Toso
From: Victor Toso Spice client should listen to SpiceMainChannel::agent-connected notification and avoid calling any clipboard related functions such as spice_gtk_session_paste_from_guest() from client-gtk library. This patch removes the silent return of agent_clipboard_grab() in order to proper