Re: [Spice-devel] [spice-gtk v3 02/16] file-xfer: introduce flush_callback and flush_done

2016-06-03 Thread Victor Toso
Hi, On Thu, Jun 02, 2016 at 08:20:02AM +0200, Pavel Grunt wrote: > On Wed, 2016-06-01 at 16:23 +0200, Victor Toso wrote: > > Hi, > > > > On Wed, Jun 01, 2016 at 03:24:09PM +0200, Pavel Grunt wrote: > > > Hi Victor, > > > > > > I put some questions/comments inline > > > > > > On Mon, 2016-05-30

Re: [Spice-devel] [spice-gtk v3 02/16] file-xfer: introduce flush_callback and flush_done

2016-06-02 Thread Pavel Grunt
On Wed, 2016-06-01 at 16:23 +0200, Victor Toso wrote: > Hi, > > On Wed, Jun 01, 2016 at 03:24:09PM +0200, Pavel Grunt wrote: > > Hi Victor, > > > > I put some questions/comments inline > > > > On Mon, 2016-05-30 at 11:54 +0200, Victor Toso wrote: > > > By introducing a flush_callback such as

Re: [Spice-devel] [spice-gtk v3 02/16] file-xfer: introduce flush_callback and flush_done

2016-06-01 Thread Victor Toso
Hi, On Wed, Jun 01, 2016 at 03:24:09PM +0200, Pavel Grunt wrote: > Hi Victor, > > I put some questions/comments inline > > On Mon, 2016-05-30 at 11:54 +0200, Victor Toso wrote: > > By introducing a flush_callback such as SpiceFileTransferTaskFlushCb > > SpiceFileTransferTask becomes agnostic on

[Spice-devel] [spice-gtk v3 02/16] file-xfer: introduce flush_callback and flush_done

2016-05-30 Thread Victor Toso
By introducing a flush_callback such as SpiceFileTransferTaskFlushCb SpiceFileTransferTask becomes agnostic on how channel-main flushes the data. The spice_file_transfer_task_flush_done() function is now introduced to tell SpiceFileTransferTask that flushing is over and we can read more data if