Re: [Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

2019-03-11 Thread Christophe Fergeau
On Mon, Mar 11, 2019 at 12:12:45PM +, Victor Toso wrote: > Hi, > > On Mon, Mar 11, 2019 at 12:33:20PM +0100, Christophe Fergeau wrote: > > Hey, > > > > One comment, even if the commit log mentions a bug #, it does not seem > > to be describing what the bug is/how it's fixed (maybe this can be

Re: [Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

2019-03-11 Thread Victor Toso
Hi, On Mon, Mar 11, 2019 at 07:34:19AM -0400, Frediano Ziglio wrote: > > Changes v1->v2 > > * Using reds_core_timer_* api, which calls the timeout function from the > > right context (Frediano); > > Sorry, these functions suffers the same problem, you have to > use the core interface of the Dis

Re: [Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

2019-03-11 Thread Victor Toso
Hi, On Mon, Mar 11, 2019 at 12:33:20PM +0100, Christophe Fergeau wrote: > Hey, > > One comment, even if the commit log mentions a bug #, it does not seem > to be describing what the bug is/how it's fixed (maybe this can be > inferred from the traces, but I did not read them closely as the log > d

Re: [Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

2019-03-11 Thread Frediano Ziglio
> > From: Victor Toso > > The device driver might take a few interactions to reconfigure all > displays but in each change it can send it down to spice-server. The > client is not interested in temporary states, only the final monitor > config can be helpful. > > This patch adds a 200ms delay t

Re: [Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

2019-03-11 Thread Christophe Fergeau
Hey, One comment, even if the commit log mentions a bug #, it does not seem to be describing what the bug is/how it's fixed (maybe this can be inferred from the traces, but I did not read them closely as the log does not hint that a bug can be seen by looking at them). Christophe On Mon, Mar 11,

[Spice-devel] [spice v2] display-channel: monitors_config: add 200ms delay

2019-03-11 Thread Victor Toso
From: Victor Toso The device driver might take a few interactions to reconfigure all displays but in each change it can send it down to spice-server. The client is not interested in temporary states, only the final monitor config can be helpful. This patch adds a 200ms delay to wait for more cha