Re: [Spice-devel] [vdagent-linux v2 2/2] systemd: Remove WantedBy=sockets.service in [Install]

2018-12-19 Thread Christophe Fergeau
On Wed, Dec 19, 2018 at 09:55:52AM -0500, Frediano Ziglio wrote: > Out of this patch but related. What will happen to systems during upgrade? > Will the dependency (sockets.target wants spice-vdagentd.socket) removed? > I suppose for RPM the script will do it, not sure about a possible > "make

Re: [Spice-devel] [vdagent-linux v2 2/2] systemd: Remove WantedBy=sockets.service in [Install]

2018-12-19 Thread Frediano Ziglio
> > .socket systemd units already automatically get a > Before=sockets.service, and the udev rule we have will ensure that when > the appropriate virtio device is there, the socket unit will be started, > so this WantedBy dependency is not needed, and is in part responsible > for these warnings:

[Spice-devel] [vdagent-linux v2 2/2] systemd: Remove WantedBy=sockets.service in [Install]

2018-12-19 Thread Christophe Fergeau
.socket systemd units already automatically get a Before=sockets.service, and the udev rule we have will ensure that when the appropriate virtio device is there, the socket unit will be started, so this WantedBy dependency is not needed, and is in part responsible for these warnings: [ INFO ]