Re: [Spice-devel] SPICE logging facilities

2018-07-05 Thread Victor Toso
Hi, On Wed, Jul 04, 2018 at 12:29:15PM -0400, Frediano Ziglio wrote: > > > > On Wed, Jul 04, 2018 at 11:38:14AM -0400, Frediano Ziglio wrote: > > > Another question is however "Are we going to use g_critical > > > as g_critical?". It sounds a tricky question. Let say that > > > a new person start

Re: [Spice-devel] SPICE logging facilities

2018-07-05 Thread Christophe Fergeau
On Wed, Jul 04, 2018 at 12:29:15PM -0400, Frediano Ziglio wrote: > > > > On Wed, Jul 04, 2018 at 11:38:14AM -0400, Frediano Ziglio wrote: > > > Another question is however "Are we going to use g_critical as > > > g_critical?". It sounds a tricky question. Let say that a new person > > > starts to

Re: [Spice-devel] SPICE logging facilities

2018-07-04 Thread Frediano Ziglio
> > On Wed, Jul 04, 2018 at 11:38:14AM -0400, Frediano Ziglio wrote: > > Another question is however "Are we going to use g_critical as > > g_critical?". It sounds a tricky question. Let say that a new person > > starts to look at the code and knows GLib. He see g_critical and > > think "well, thi

Re: [Spice-devel] SPICE logging facilities

2018-07-04 Thread Christophe Fergeau
On Wed, Jul 04, 2018 at 11:38:14AM -0400, Frediano Ziglio wrote: > Another question is however "Are we going to use g_critical as > g_critical?". It sounds a tricky question. Let say that a new person > starts to look at the code and knows GLib. He see g_critical and > think "well, this by default

Re: [Spice-devel] SPICE logging facilities

2018-07-04 Thread Frediano Ziglio
> > Hi, > > On Wed, Jul 04, 2018 at 11:21:56AM +0200, Christophe Fergeau wrote: > > On Tue, Jul 03, 2018 at 05:10:23PM +0200, Christophe de Dinechin wrote: > > > There is a lot of debate, distributed across a large number of patches, > > > regarding similar SPICE and glib facilities. For a number

Re: [Spice-devel] SPICE logging facilities

2018-07-04 Thread Victor Toso
Hi, On Wed, Jul 04, 2018 at 11:21:56AM +0200, Christophe Fergeau wrote: > On Tue, Jul 03, 2018 at 05:10:23PM +0200, Christophe de Dinechin wrote: > > There is a lot of debate, distributed across a large number of patches, > > regarding similar SPICE and glib facilities. For a number of things, th

Re: [Spice-devel] SPICE logging facilities

2018-07-04 Thread Christophe Fergeau
On Tue, Jul 03, 2018 at 05:10:23PM +0200, Christophe de Dinechin wrote: > There is a lot of debate, distributed across a large number of patches, > regarding similar SPICE and glib facilities. For a number of things, there > are two sets of parallel APIs with slightly different behaviour. This is

Re: [Spice-devel] SPICE logging facilities

2018-07-03 Thread Jonathon Jongsma
On Tue, 2018-07-03 at 17:10 +0200, Christophe de Dinechin wrote: > There is a lot of debate, distributed across a large number of > patches, regarding similar SPICE and glib facilities. For a number of > things, there are two sets of parallel APIs with slightly different > behaviour. This is undesi

[Spice-devel] SPICE logging facilities

2018-07-03 Thread Christophe de Dinechin
There is a lot of debate, distributed across a large number of patches, regarding similar SPICE and glib facilities. For a number of things, there are two sets of parallel APIs with slightly different behaviour. This is undesirable, as it introduces confusion. Pros: this lets us customize the b