[Spice-devel] spice-gtk how to use opengl

2013-11-20 Thread thddu
Old spicec can use canvas type gl_fbo and gl_pbuff . But when i connect to spice server , spicec core dumped and print Spice-Warning **: ../spice-common/common/canvas_base.c:1145:canvas_get_image_internal: should not be reached. In addition, spice gtk can't choose canvas type.

[Spice-devel] spice-gtk how to use opengl

2013-11-20 Thread thddu
Old spicec can use canvas type gl_fbo and gl_pbuff . But when i connect to spice server , spicec core dumped and print Spice-Warning **: ../spice-common/common/canvas_base.c:1145:canvas_get_image_internal: should not be reached. In addition, spice gtk can't choose canvas type.

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Marc-André Lureau
On Tue, Nov 19, 2013 at 10:23 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Make the coroutine code more glib-like, by aborting on OOM or unhandled conditions. --- gtk/continuation.c| 9 - gtk/continuation.h| 2 +- gtk/coroutine.h | 3 ++-

Re: [Spice-devel] spice-gtk how to use opengl

2013-11-20 Thread Marc-André Lureau
- Original Message - Old spicec can use canvas type gl_fbo and gl_pbuff . But when i connect to spice server , spicec core dumped and print Spice-Warning **: ../spice-common/common/canvas_base.c:1145:canvas_get_image_internal: should not be reached. How did you compile spice, do you

Re: [Spice-devel] Spice stops working when host uses multi-monitors

2013-11-20 Thread Diego COSTE
Hello Christophe, After several tests, I finally found that the problem is due to some network settings. Although I have not understood everything (I don't know much about networking), I now have a way that works fine: - I start virt-manager from a shell with the correct network config (incl.

[Spice-devel] [PATCH spice-gtk] main: fix recent main_channel_reset() warning

2013-11-20 Thread Marc-André Lureau
Fix wrong warning added in 0704147d. (lt-spicy:17511): GSpice-WARNING **: (channel-main.c:415):spice_main_channel_reset: runtime check failed: (c-agent_connected == FALSE) --- gtk/channel-main.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice-gtk] main: fix recent main_channel_reset() warning

2013-11-20 Thread Christophe Fergeau
ACK On Wed, Nov 20, 2013 at 12:28:49PM +0100, Marc-André Lureau wrote: Fix wrong warning added in 0704147d. (lt-spicy:17511): GSpice-WARNING **: (channel-main.c:415):spice_main_channel_reset: runtime check failed: (c-agent_connected == FALSE) --- gtk/channel-main.c | 17 -

[Spice-devel] [spice-gtk] Fix 'monitors' leak in update_monitor_area()

2013-11-20 Thread Christophe Fergeau
This function has an early return where we fail to unref the 'monitors' array. --- gtk/spice-widget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 0447dda..4e76648 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c @@ -302,6 +302,7 @@

Re: [Spice-devel] [spice-gtk] Fix 'monitors' leak in update_monitor_area()

2013-11-20 Thread Marc-André Lureau
ack - Original Message - This function has an early return where we fail to unref the 'monitors' array. --- gtk/spice-widget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 0447dda..4e76648 100644 --- a/gtk/spice-widget.c +++

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Christophe Fergeau
On Tue, Nov 19, 2013 at 10:23:00PM +0100, Marc-André Lureau wrote: diff --git a/spice-common b/spice-common index 1450bb4..261d270 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit 1450bb4ddbd8ceab9192e4f84606aa5ae54c5ea6 +Subproject commit

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Christophe Fergeau
On Tue, Nov 19, 2013 at 10:23:00PM +0100, Marc-André Lureau wrote: Make the coroutine code more glib-like, by aborting on OOM or unhandled conditions. Once again, 'glib-like' is vague enough that it does not mean much, glib is not aborting on all system errors. Let's just say for coroutines we

Re: [Spice-devel] [spice-protocol opus support 1/6 (take 3)] Add support for the Opus codec

2013-11-20 Thread Christophe Fergeau
ACK On Tue, Nov 12, 2013 at 03:52:28PM -0600, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com --- spice/enums.h|1 + spice/protocol.h |2 ++ 2 files changed, 3 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index f192e43..fdcffa8 100644 ---

Re: [Spice-devel] [spice-common opus support 2/6 (take 3)] Add support for the Opus codec.

2013-11-20 Thread Christophe Fergeau
ACK On Tue, Nov 12, 2013 at 03:52:36PM -0600, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com --- common/Makefile.am |2 + common/snd_codec.c | 136 +--- common/snd_codec.h | 20 ++-- configure.ac |

Re: [Spice-devel] [spice opus support 4/6 (take 3)] Fix typo; sampel -- sample

2013-11-20 Thread Christophe Fergeau
ACK On Tue, Nov 12, 2013 at 03:53:02PM -0600, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com --- client/platform.h |4 ++-- client/windows/platform.cpp |8 client/windows/playback.cpp | 14 +++--- client/windows/playback.h |

[Spice-devel] ovirt authentication and the authenticate signal

2013-11-20 Thread i iordanov
Hi Christophe, Does the OvirtProxy object always need to authenticate by emitting the authenticate signal? It seems to still emit the signal even though I set its username and password properties a priori with known good values. Am I doing something wrong, or is it meant to behave this way?