Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
On Wed, Aug 27, 2014 at 08:51:10PM +0200, Marc-André Lureau wrote: > From: Marc-Andre Lureau > > Make sure vdagent follows the current monitor configuration. This > solves a number of issue where the pointer input is off, because the > uinput tablet isn't reconfigured. > > https://bugzilla.redh

[Spice-devel] [PATCH 2/4] Add missing doc for SPICE_CLIENT_USB* errors

2014-10-08 Thread Fabiano Fidêncio
--- gtk/spice-client.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/spice-client.h b/gtk/spice-client.h index 0e1e49d..f1a7fb3 100644 --- a/gtk/spice-client.h +++ b/gtk/spice-client.h @@ -56,6 +56,8 @@ G_BEGIN_DECLS /** * SpiceClientError: * @SPICE_CLIENT_ERROR_FAILED: generic er

[Spice-devel] [v4: PATCH 4/4] Add support to handle username when connecting with SASL

2014-10-08 Thread Fabiano Fidêncio
Based on a patch from Dietmar Maurer http://lists.freedesktop.org/archives/spice-devel/2013-October/015138.html --- Changes since v3: - Reset auth_needs_username_and_password in channel_reset(), so object could be recycled in clean state. --- gtk/spice-channel-priv.h | 1 + gtk/spice-channel.c

[Spice-devel] [v4: PATCH 3/4] Add errors related to the SASL auth

2014-10-08 Thread Fabiano Fidêncio
SPICE_CLIENT_ERROR_AUTH_* will be used to set more detailed errors with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. --- Changes since v3: - Add docs for the SPICE_CLIENT_ERROR_AUTH* --- gtk/spice-client.h | 4 1 file changed, 4 insertions(+) diff --git a/gtk/spice-client.h b/

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 2:07 PM, Christophe Fergeau wrote: > On Wed, Aug 27, 2014 at 08:51:10PM +0200, Marc-André Lureau wrote: > > From: Marc-Andre Lureau > > > > Make sure vdagent follows the current monitor configuration. This > > solves a number of issue where the pointer input is off, becau

Re: [Spice-devel] [v4: PATCH 3/4] Add errors related to the SASL auth

2014-10-08 Thread Marc-André Lureau
ack - Original Message - > SPICE_CLIENT_ERROR_AUTH_* will be used to set more detailed errors > with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. > --- > Changes since v3: > - Add docs for the SPICE_CLIENT_ERROR_AUTH* > --- > gtk/spice-client.h | 4 > 1 file changed,

Re: [Spice-devel] [v4: PATCH 4/4] Add support to handle username when connecting with SASL

2014-10-08 Thread Marc-André Lureau
- Original Message - > Based on a patch from Dietmar Maurer > http://lists.freedesktop.org/archives/spice-devel/2013-October/015138.html > --- > Changes since v3: > - Reset auth_needs_username_and_password in channel_reset(), so object could > be > recycled in clean state. > --- > gtk

Re: [Spice-devel] [PATCH 2/4] Add missing doc for SPICE_CLIENT_USB* errors

2014-10-08 Thread Marc-André Lureau
ack - Original Message - > --- > gtk/spice-client.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gtk/spice-client.h b/gtk/spice-client.h > index 0e1e49d..f1a7fb3 100644 > --- a/gtk/spice-client.h > +++ b/gtk/spice-client.h > @@ -56,6 +56,8 @@ G_BEGIN_DECLS > /** > * Spic

Re: [Spice-devel] [v3: PATCH 1/3] Add "username" property to SpiceSession

2014-10-08 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 01:23:06PM +0200, Fabiano Fidêncio wrote: > From: Dietmar Maurer > > --- > No changes since v2 > --- > gtk/spice-session-priv.h | 2 ++ > gtk/spice-session.c | 63 > +--- > 2 files changed, 61 insertions(+), 4 deletions(-

[Spice-devel] [v4: PATCH 1/4] Add "username" property to SpiceSession

2014-10-08 Thread Fabiano Fidêncio
From: Dietmar Maurer --- Changes since v3: - Simplify the code to get the username from the URI --- gtk/spice-session-priv.h | 2 ++ gtk/spice-session.c | 56 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/gtk/spice-session-

Re: [Spice-devel] [vdagent-linux 1/2] randr: remove monitors.xml on auto-configuration

2014-10-08 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 02:04:38PM +0200, Marc-André Lureau wrote: > On Wed, Oct 8, 2014 at 1:11 PM, Christophe Fergeau > wrote: > > > > You make it sound like it's only an issue when running GNOME2. If you > > > > I already mentionned recent gnome3 auto-config has been merged in (last > year) a

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 02:25:08PM +0200, Marc-André Lureau wrote: > On Wed, Oct 8, 2014 at 2:07 PM, Christophe Fergeau > wrote: > > > On Wed, Aug 27, 2014 at 08:51:10PM +0200, Marc-André Lureau wrote: > > > From: Marc-Andre Lureau > > > > > > Make sure vdagent follows the current monitor config

Re: [Spice-devel] [v4: PATCH 1/4] Add "username" property to SpiceSession

2014-10-08 Thread Christophe Fergeau
Looks good to me, thanks for the additional iteration! Christophe On Wed, Oct 08, 2014 at 03:20:11PM +0200, Fabiano Fidêncio wrote: > From: Dietmar Maurer > > --- > Changes since v3: > - Simplify the code to get the username from the URI > --- > gtk/spice-session-priv.h | 2 ++ > gtk/spice-se

Re: [Spice-devel] [vdagent-linux 1/2] randr: remove monitors.xml on auto-configuration

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 3:21 PM, Christophe Fergeau wrote: > gnome2 is obsolete, not using client monitor config is getting obsolete, > and removing a file which we don't own is a very heavy hammer, > A hammer? monitors.xml is a user config, safe to delete, "well-known" file name (in gnomerr API

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 3:23 PM, Christophe Fergeau wrote: > > RRCrtcChangeNotify is a event subtype of RRNotify, since that's the only > > one we can catch here, no need to filter futher. > > well, let's use the more specific type then, this is the one which was > used before so it makes things e

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 03:49:29PM +0200, Marc-André Lureau wrote: > On Wed, Oct 8, 2014 at 3:23 PM, Christophe Fergeau > wrote: > > > > RRCrtcChangeNotify is a event subtype of RRNotify, since that's the only > > > one we can catch here, no need to filter futher. > > > > well, let's use the more

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
And I forgot again to mention that you need a #include or this won't compile because of TRUE/FALSE. Christophe On Wed, Oct 08, 2014 at 03:59:57PM +0200, Christophe Fergeau wrote: > On Wed, Oct 08, 2014 at 03:49:29PM +0200, Marc-André Lureau wrote: > > On Wed, Oct 8, 2014 at 3:23 PM, Christophe F

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 4:07 PM, Christophe Fergeau wrote: > And I forgot again to mention that you need a #include or this > won't compile because of TRUE/FALSE. > right, it was meant to be applied after the "remove monitors.xml", but I can reorder it. -- Marc-André Lureau __

Re: [Spice-devel] [PATCH spice] Provide thread safety between spice_server_playback_put_samples and snd_set_playback_latency.

2014-10-08 Thread Marc-André Lureau
On Wed, Sep 24, 2014 at 8:06 PM, Jeremy White wrote: > A MsgMainMultiMediaTime message on the main channel will be relayed > through main_dispatcher so as to be fired in the context of the > main (not worker) thread. > > In qemu, that thread happens to also be the thread that drives the > audio c

Re: [Spice-devel] [PATCH spice] Provide thread safety between spice_server_playback_put_samples and snd_set_playback_latency.

2014-10-08 Thread Jeremy White
Is this difficult to solve? It seems the thread is reading from a fd and pushing to spice server. Couldn't this be done from X main loop? Yes, that may be possible. There are some tricks with the timing that may make that challenging (e.g. we need to feed audio at regular intervals). I also

Re: [Spice-devel] [PATCH spice] Provide thread safety between spice_server_playback_put_samples and snd_set_playback_latency.

2014-10-08 Thread Marc-André Lureau
Hi - Original Message - > > > > Is this difficult to solve? It seems the thread is reading from a fd and > > pushing to spice server. Couldn't this be done from X main loop? > > Yes, that may be possible. There are some tricks with the timing that > may make that challenging (e.g. we ne

Re: [Spice-devel] [v2: PATCH 1/3] Add SpiceChannelError

2014-10-08 Thread Marc-André Lureau
On Mon, Oct 6, 2014 at 4:23 PM, Christophe Fergeau wrote: > ACK > > On Mon, Oct 06, 2014 at 01:52:43PM +0200, Fabiano Fidêncio wrote: > > SpiceChannelError, for now, will be used to set more detailed errors > > with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. > > --- > > Changes s

Re: [Spice-devel] [v2: PATCH 1/3] Add SpiceChannelError

2014-10-08 Thread Fabiano Fidêncio
On Wed, Oct 8, 2014 at 11:06 AM, Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > > > On Mon, Oct 6, 2014 at 4:23 PM, Christophe Fergeau > wrote: > >> ACK >> >> On Mon, Oct 06, 2014 at 01:52:43PM +0200, Fabiano Fidêncio wrote: >> > SpiceChannelError, for now, will be used to set more deta

Re: [Spice-devel] [v2: PATCH 1/3] Add SpiceChannelError

2014-10-08 Thread Marc-André Lureau
- Original Message - > > > On Wed, Oct 8, 2014 at 11:06 AM, Marc-André Lureau < > marcandre.lur...@gmail.com > wrote: > > > > > > On Mon, Oct 6, 2014 at 4:23 PM, Christophe Fergeau < cferg...@redhat.com > > wrote: > > > ACK > > On Mon, Oct 06, 2014 at 01:52:43PM +0200, Fabiano F

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
ping On Mon, Sep 8, 2014 at 11:34 AM, Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > ping > > > On Wed, Aug 27, 2014 at 8:51 PM, Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > >> From: Marc-Andre Lureau >> >> Make sure vdagent follows the current monitor configuration. Th

Re: [Spice-devel] [vdagent-linux 1/2] randr: remove monitors.xml on auto-configuration

2014-10-08 Thread Marc-André Lureau
Hi On Thu, Oct 2, 2014 at 2:10 PM, Christophe Fergeau wrote: > Hey, > > On Wed, Aug 27, 2014 at 07:22:07PM +0200, Marc-André Lureau wrote: > > From: Marc-Andre Lureau > > > > GNOME will restore monitors.xml configuration whenever the timestamp > > "config > change". The "change" timestamp is th

[Spice-devel] [v3: PATCH 2/3] Add errors related to the SASL auth

2014-10-08 Thread Fabiano Fidêncio
SPICE_CLIENT_ERROR_AUTH_* will be used to set more detailed errors with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. --- Changes since v2: - Use SPICE_CLIENT_ERROR domain instead of create a new one --- gtk/spice-client.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/spi

[Spice-devel] [v3: PATCH 1/3] Add "username" property to SpiceSession

2014-10-08 Thread Fabiano Fidêncio
From: Dietmar Maurer --- No changes since v2 --- gtk/spice-session-priv.h | 2 ++ gtk/spice-session.c | 63 +--- 2 files changed, 61 insertions(+), 4 deletions(-) diff --git a/gtk/spice-session-priv.h b/gtk/spice-session-priv.h index 4b2c151..da

[Spice-devel] [v3: PATCH 3/3] Add support to handle username when connecting with SASL

2014-10-08 Thread Fabiano Fidêncio
Based on a patch from Dietmar Maurer http://lists.freedesktop.org/archives/spice-devel/2013-October/015138.html --- Changes since v2: - Adapt the code to set errors from SPICE_CLIENT_ERROR domain instead of SPICE_CHANELL_ERROR_AUTH --- gtk/spice-channel-priv.h | 1 + gtk/spice-channel.c |

Re: [Spice-devel] [v3: PATCH 1/3] Add "username" property to SpiceSession

2014-10-08 Thread Marc-André Lureau
ack - Original Message - > From: Dietmar Maurer > > --- > No changes since v2 > --- > gtk/spice-session-priv.h | 2 ++ > gtk/spice-session.c | 63 > +--- > 2 files changed, 61 insertions(+), 4 deletions(-) > > diff --git a/gtk/spice-se

Re: [Spice-devel] [v3: PATCH 2/3] Add errors related to the SASL auth

2014-10-08 Thread Marc-André Lureau
Could you add doc above? (even though it's missing USB errors), ack otherwise - Original Message - > SPICE_CLIENT_ERROR_AUTH_* will be used to set more detailed errors > with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. > --- > Changes since v2: > - Use SPICE_CLIENT_ERROR do

Re: [Spice-devel] [v3: PATCH 3/3] Add support to handle username when connecting with SASL

2014-10-08 Thread Marc-André Lureau
- Original Message - > Based on a patch from Dietmar Maurer > http://lists.freedesktop.org/archives/spice-devel/2013-October/015138.html > --- > Changes since v2: > - Adapt the code to set errors from SPICE_CLIENT_ERROR domain instead of > SPICE_CHANELL_ERROR_AUTH > --- > gtk/spice-ch

Re: [Spice-devel] [vdagent-linux 1/2] randr: remove monitors.xml on auto-configuration

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 1:11 PM, Christophe Fergeau wrote: > On Wed, Oct 08, 2014 at 12:28:53PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Thu, Oct 2, 2014 at 2:10 PM, Christophe Fergeau > > wrote: > > > > > Hey, > > > > > > On Wed, Aug 27, 2014 at 07:22:07PM +0200, Marc-André Lureau wrote