[Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

2016-01-06 Thread Christophe Fergeau
This should make things more portable. https://bugs.freedesktop.org/show_bug.cgi?id=86997 --- spice/barrier.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/spice/barrier.h b/spice/barrier.h index 710da09..7d63721 100644 --- a/spice/barrier.h +++ b/spice/barrier.h @@ -3

Re: [Spice-devel] [PATCH 1/3] protocol: Add macros to help convert QXLPHYSICAL to/from pointers

2016-01-06 Thread Christophe Fergeau
Hey, On Mon, Dec 28, 2015 at 11:06:37AM +0100, Francois Gouget wrote: > On 32 bit systems the QXLPHYSICAL integer size deos not match the size > of a pointer so special care must be taken in the conversions to avoid > compiler errors with -Werror. In general (virtualization usecase), you cannot c

Re: [Spice-devel] [PATCH 3/3] server: Use the QXLPHYSICAL macros for conversions to/from pointers

2016-01-06 Thread Christophe Fergeau
On Mon, Dec 28, 2015 at 11:06:47AM +0100, Francois Gouget wrote: > This avoids compilation errors with -Werror on 32 bit systems. > > Signed-off-by: Francois Gouget > --- > src/spiceqxl_display.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/spiceqxl_display.c b

Re: [Spice-devel] [PATCH 1/3] protocol: Add macros to help convert QXLPHYSICAL to/from pointers

2016-01-06 Thread Christophe Fergeau
On Mon, Dec 28, 2015 at 11:06:37AM +0100, Francois Gouget wrote: > On 32 bit systems the QXLPHYSICAL integer size deos not match the size > of a pointer so special care must be taken in the conversions to avoid > compiler errors with -Werror. > > Signed-off-by: Francois Gouget > --- > spice/qxl_

Re: [Spice-devel] [PATCH 2/3] server: Use the QXLPHYSICAL macros for conversions to/from pointers

2016-01-06 Thread Christophe Fergeau
Hey, The patch looks good, however I think it would be better to use memslots, replay.c registers a dummy one with spice-server with a 0 base address/offset, so casting between pointers and QXLPHYSICAL works. Passing the memslot info to red_replay_new() and using this for address translations woul

Re: [Spice-devel] How to get sound working from guest VM?

2016-01-06 Thread Christophe Fergeau
Hey, On Thu, Dec 24, 2015 at 10:51:20AM +0200, Andrey Aleksandrovich wrote: > Hi, Can you help me in my problem? > The host system is Gentoo Linux, KDE (I have tried both VLC/Gstreamer > sound engines), Qemu, virt-manager. I have installed Windows XP as > guest OS. Everything is OK, except sound

Re: [Spice-devel] [PATCH] dcc: free glz buffer after zlib compression

2016-01-06 Thread Christophe Fergeau
On Tue, Dec 22, 2015 at 07:26:42PM +, Frediano Ziglio wrote: > For zlib+glz compression image if first compressed with glz then the > resulting buffer is compressed again with zlib then the buffer from > zlib is returned to the caller. > However the temporary glz buffer was not freed resulting

Re: [Spice-devel] Clients, Nagle and net test

2016-01-06 Thread Christophe Fergeau
Hey, On Tue, Dec 22, 2015 at 11:03:47AM -0500, Frediano Ziglio wrote: > Hi, > today I was trying to do some (quick) tests for the Glib code trying to > play with > bandwidth and latency. > > I noted that the net test was giving very strange results. With a delay of > 1ms and a > bandwidth of

Re: [Spice-devel] Thoughts / questions on Xspice

2016-01-06 Thread Christophe Fergeau
Hey, On Fri, Dec 18, 2015 at 10:21:58AM -0600, Jeremy White wrote: > I've spent some time this past week relearning some of the details of > the way Xspice interacts with the Spice server; I thought I'd share my > questions and thoughts, and potential plans for the future. > > First, I have a big

Re: [Spice-devel] [PATCH 4/4] channel: use iface parameter to distinguish interface context

2016-01-06 Thread Christophe Fergeau
On Mon, Dec 21, 2015 at 10:33:12AM +, Frediano Ziglio wrote: > --- > server/red-worker.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/server/red-worker.c b/server/red-worker.c > index b0b7df1..0347404 100644 > --- a/server/red-worker.c > +++ b/server/r

Re: [Spice-devel] [PATCH 4/4] channel: use iface parameter to distinguish interface context

2016-01-06 Thread Uri Lublin
On 01/06/2016 07:09 PM, Christophe Fergeau wrote: On Mon, Dec 21, 2015 at 10:33:12AM +, Frediano Ziglio wrote: --- server/red-worker.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/server/red-worker.c b/server/red-worker.c index b0b7df1..0347404 100644 -