Follow up to 5fba8dd1a346248f215f0167d113fb20a7bb733a
to make it easier to enable them
---
Suggested by Christophe in:
https://lists.freedesktop.org/archives/spice-devel/2016-November/033824.html
---
.gitlab-ci.yml | 2 +-
configure.ac | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
On Mon, Nov 28, 2016 at 03:11:18PM +0100, Pavel Grunt wrote:
> Building spice or spice-gtk from git requires python modules pyparsing
> and six. Search for them in the both Python versions and set
> the Python version accordingly.
> ---
> v2: Keep user set (required) version of Python
> ---
> m4/s
Thanks :)
Acked-by: Christophe Fergeau
On Tue, Nov 29, 2016 at 09:38:27AM +0100, Pavel Grunt wrote:
> Follow up to 5fba8dd1a346248f215f0167d113fb20a7bb733a
> to make it easier to enable them
> ---
> Suggested by Christophe in:
> https://lists.freedesktop.org/archives/spice-devel/2016-November/0
>
> On Fri, 2016-11-25 at 14:52 +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> Acked-by: Pavel Grunt
> > ---
> > server/tests/replay.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/server/tests/replay.c b/server/tests/replay.c
> > index f32f
On Tue, 2016-11-29 at 09:52 +0100, Christophe Fergeau wrote:
> On Mon, Nov 28, 2016 at 03:11:18PM +0100, Pavel Grunt wrote:
> > Building spice or spice-gtk from git requires python modules
> > pyparsing
> > and six. Search for them in the both Python versions and set
> > the Python version accordin
On Tue, Nov 29, 2016 at 10:09:43AM +0100, Pavel Grunt wrote:
> On Tue, 2016-11-29 at 09:52 +0100, Christophe Fergeau wrote:
> > On Mon, Nov 28, 2016 at 03:11:18PM +0100, Pavel Grunt wrote:
> > > Building spice or spice-gtk from git requires python modules
> > > pyparsing
> > > and six. Search for t
On Tue, 2016-11-29 at 04:03 -0500, Frediano Ziglio wrote:
> >
> > On Fri, 2016-11-25 at 14:52 +, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio
> >
> > Acked-by: Pavel Grunt
> > > ---
> > > server/tests/replay.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
On Tue, 2016-11-29 at 10:12 +0100, Christophe Fergeau wrote:
> On Tue, Nov 29, 2016 at 10:09:43AM +0100, Pavel Grunt wrote:
> > On Tue, 2016-11-29 at 09:52 +0100, Christophe Fergeau wrote:
> > > On Mon, Nov 28, 2016 at 03:11:18PM +0100, Pavel Grunt wrote:
> > > > Building spice or spice-gtk from gi
On Thu, Nov 24, 2016 at 10:43:50AM -0500, Frediano Ziglio wrote:
> >
> > On Thu, 2016-11-24 at 09:33 -0500, Frediano Ziglio wrote:
> > > >
> > > > LZ4 changed versioning scheme from r131 to v1.7.3 making our
> > > > configure
> > > > fail with (1.7.3 < 129).
> > > >
> > > > Switch from version c
On Tue, Nov 29, 2016 at 10:18:46AM +0100, Pavel Grunt wrote:
> On Tue, 2016-11-29 at 10:12 +0100, Christophe Fergeau wrote:
> > On Tue, Nov 29, 2016 at 10:09:43AM +0100, Pavel Grunt wrote:
> > > On Tue, 2016-11-29 at 09:52 +0100, Christophe Fergeau wrote:
> > > > On Mon, Nov 28, 2016 at 03:11:18PM
>
> On Tue, 2016-11-29 at 04:03 -0500, Frediano Ziglio wrote:
> > >
> > > On Fri, 2016-11-25 at 14:52 +, Frediano Ziglio wrote:
> > > > Signed-off-by: Frediano Ziglio
> > >
> > > Acked-by: Pavel Grunt
> > > > ---
> > > > server/tests/replay.c | 2 +-
> > > > 1 file changed, 1 insertion(+)
On Tue, 2016-11-29 at 04:37 -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2016-11-29 at 04:03 -0500, Frediano Ziglio wrote:
> > > >
> > > > On Fri, 2016-11-25 at 14:52 +, Frediano Ziglio wrote:
> > > > > Signed-off-by: Frediano Ziglio
> > > >
> > > > Acked-by: Pavel Grunt
> > > > > ---
> >
On Tue, 2016-11-29 at 10:34 +0100, Christophe Fergeau wrote:
> On Tue, Nov 29, 2016 at 10:18:46AM +0100, Pavel Grunt wrote:
> > On Tue, 2016-11-29 at 10:12 +0100, Christophe Fergeau wrote:
> > > On Tue, Nov 29, 2016 at 10:09:43AM +0100, Pavel Grunt wrote:
> > > > On Tue, 2016-11-29 at 09:52 +0100,
On Tue, Nov 29, 2016 at 11:06:04AM +0100, Pavel Grunt wrote:
> On Tue, 2016-11-29 at 10:34 +0100, Christophe Fergeau wrote:
> > On Tue, Nov 29, 2016 at 10:18:46AM +0100, Pavel Grunt wrote:
> > > On Tue, 2016-11-29 at 10:12 +0100, Christophe Fergeau wrote:
> > > > On Tue, Nov 29, 2016 at 10:09:43AM
Missing log
On Wed, Nov 23, 2016 at 06:07:16PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 79
> +++---
> 1 file changed, 37 insertions(+), 42 deletions(-)
>
> diff --git a/server/sound.c b/server/
On Wed, Nov 23, 2016 at 06:07:18PM +, Frediano Ziglio wrote:
> SndChannel -> SndChannelClient
> SndWorker -> SndChannel
I'd expect an explanation as to why what was called a SndChannel so far
really is a SndChannelClient (as it's going to inherit from
RedChannelClient in the future). Ditto for
Use same constants for common commands.
This will allow code reuse between Record and Playback.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 79 +++---
1 file changed, 37 insertions(+), 42 deletions(-)
Changes since v1:
- extend commit
On 11/28/2016 07:50 PM, Frediano Ziglio wrote:
This make compression faster and avoids a warning on newer
lz4 versions.
Signed-off-by: Frediano Ziglio
---
server/lz4-encoder.c | 9 -
spice-common | 2 +-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/server/lz4-
>
> On Wed, Nov 23, 2016 at 06:07:18PM +, Frediano Ziglio wrote:
> > SndChannel -> SndChannelClient
> > SndWorker -> SndChannel
>
> I'd expect an explanation as to why what was called a SndChannel so far
> really is a SndChannelClient (as it's going to inherit from
> RedChannelClient in the f
>
> On 11/28/2016 07:50 PM, Frediano Ziglio wrote:
> > This make compression faster and avoids a warning on newer
> > lz4 versions.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/lz4-encoder.c | 9 -
> > spice-common | 2 +-
> > 2 files changed, 9 insertions(+), 2 dele
On 11/23/2016 08:07 PM, Frediano Ziglio wrote:
Acked-by: Uri Lublin
Signed-off-by: Frediano Ziglio
---
server/sound.c | 4
1 file changed, 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 6aa9e06..332cf0c 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -100,10 +100
On 11/29/2016 01:35 PM, Frediano Ziglio wrote:
Use same constants for common commands.
This will allow code reuse between Record and Playback.
Acked-by: Uri Lublin
Signed-off-by: Frediano Ziglio
---
server/sound.c | 79 +++---
1 file cha
On Tue, Nov 29, 2016 at 06:49:01AM -0500, Frediano Ziglio wrote:
> >
> > On Wed, Nov 23, 2016 at 06:07:18PM +, Frediano Ziglio wrote:
> > > SndChannel -> SndChannelClient
> > > SndWorker -> SndChannel
> >
> > I'd expect an explanation as to why what was called a SndChannel so far
> > really i
SpicePlaybackState and SpiceRecordState have same structures
changing only slightly the behaviour.
Using SndWorker instead allows some minor simplification and
more code reuse.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 26 --
1 file changed, 12 insertions(+), 14
NOTE: this is not supposed to run!
Just make easy the review, should be squashed to following 2
patches.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 195 +-
1 file changed, 130 insertions(+), 65 deletions(-)
diff --git a/server/sound.c b/
Due to object rename using channel to store a client is
quite confusing.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 520 +-
1 file changed, 260 insertions(+), 260 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 6c02754..c3
Signed-off-by: Frediano Ziglio
---
server/sound.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 6650094..737f8b9 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -176,7 +176,7 @@ typedef struct RecordChannelClient {
} Re
Avoid having dandling pointer to a client.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/server/sound.c b/server/sound.c
index 24fd729..4906122 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -773,6 +773,14 @@ static int snd_c
Almost identical beside the type.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 53 +++
1 file changed, 16 insertions(+), 37 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 654a06a..c396248 100644
--- a/server/sound.c
+++ b/s
Signed-off-by: Frediano Ziglio
---
server/sound.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index bd8812b..2560596 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -1425,9 +1425,26 @@ snd_channel_init(SndChannel *s
This code is the same inside __new_channel but will set the
RedsStream from RedChannel.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 51 +++-
1 file changed, 51 insertions(+)
diff --git a/server/sound.c b/server/sound.c
index a7622be..60412
Signed-off-by: Frediano Ziglio
---
server/sound.c | 68 +--
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index c3bb566..6650094 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -79,12 +79,12 @@ t
Signed-off-by: Frediano Ziglio
---
server/sound.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 2560596..654a06a 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -804,25 +804,6 @@ snd_channel_client_release_recv_buf(RedChannelCl
On Wed, 2016-11-09 at 17:16 +0100, Christophe Fergeau wrote:
> > - lightdm, slim, kdm: there's no way to specify a program to be
> > executed while running the greeter, must be worked around with a
> > wrapper. Changing resolution results in the greeter crashing and/or
> > hanging.
>
> What do yo
This patch is quite huge but have some benefits:
- reduce dependency (DummyChannel* and some RedChannelClient internals);
- reuse RedChannelClient instead of reading from the RedsStream
directly.
You can see that SndChannelClient has much less field
as the code to read/write from/to client is re
These objects were used by the sound channel as
this channel read/write to/from client directly.
This make the code of this channel quite different
from the other ones.
Also this reduce code duplication from RedChannelClient
and increase encapsulation.
First set of patches attempt to rename fields/
SndWorker has been historically based on RedChannel, initial git commit
has:
struct SndWorker {
Channel base;
...
};
SndChannel, contrary to what its name may imply is more focused on
marshalling/sending of sound data, which is the responsibility of
RedChannelClient for the other SPICE c
Make easier to understand that they refer to client and not
all channel.
Specifically:
- RecordChannel -> RecordChannelClient
- PlaybackChannel -> PlaybackChannelClient
- playback_channel -> playback_client
- record_channel -> record_client
Signed-off-by: Frediano Ziglio
---
server/sound.c | 36
Hey,
On Wed, Nov 23, 2016 at 06:07:25PM +, Frediano Ziglio wrote:
> This patch is quite huge but have some benefits:
> - reduce dependency (DummyChannel* and some RedChannelClient internals);
> - reuse RedChannelClient instead of reading from the RedsStream
> directly.
>
> You can see that
Signed-off-by: Frediano Ziglio
---
server/red-channel-client-private.h | 11 +++
server/red-channel-client.c | 12 ++--
server/red-channel-client.h | 13 -
3 files changed, 17 insertions(+), 19 deletions(-)
diff --git a/server/red-channel-client-privat
Signed-off-by: Frediano Ziglio
---
server/Makefile.am| 4 +-
server/dummy-channel-client.c | 138 +---
server/dummy-channel-client.h | 64 +
server/dummy-channel.c| 94 +
server/dummy-channel.h
Sound messages are not that big.
This limit RecordChannelClient to 64K so the entire
structure can be a GObject (which are currently limited
to 64K).
Signed-off-by: Frediano Ziglio
---
server/sound.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/server/sound
No more sense to still call it worker.
Signed-off-by: Frediano Ziglio
---
server/sound.c | 294 +-
1 file changed, 147 insertions(+), 147 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 737f8b9..d9b69af 100644
--- a/server/sound.c
Add it to "-chardev spicevmc" option.
Without it I get:
qemu-system-x86_64: -chardev spicevmc,name=smartcard: chardev: no id specified
Signed-off-by: Uri Lublin
---
spice-user-manual.asc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-user-manual.asc b/spice-user-manua
Also added "clients" to the sentence to make it clear
that usbdk is to be installed on the client machine.
Signed-off-by: Uri Lublin
---
spice-user-manual.asc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/spice-user-manual.asc b/spice-user-manual.asc
index 17f98f1..ed
>
> Hey,
>
> On Wed, Nov 23, 2016 at 06:07:25PM +, Frediano Ziglio wrote:
> > This patch is quite huge but have some benefits:
> > - reduce dependency (DummyChannel* and some RedChannelClient internals);
> > - reuse RedChannelClient instead of reading from the RedsStream
> > directly.
> >
On Tue, Nov 29, 2016 at 10:16:04AM -0500, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > On Wed, Nov 23, 2016 at 06:07:25PM +, Frediano Ziglio wrote:
> > > This patch is quite huge but have some benefits:
> > > - reduce dependency (DummyChannel* and some RedChannelClient internals);
> > > - reus
On 11/29/2016 01:51 PM, Frediano Ziglio wrote:
On 11/28/2016 07:50 PM, Frediano Ziglio wrote:
This make compression faster and avoids a warning on newer
lz4 versions.
Signed-off-by: Frediano Ziglio
Hi Frediano,
Nitpick: Since the functions signatures are the same,
[snipped]
LZ4_compre
>
> On Tue, Nov 29, 2016 at 10:16:04AM -0500, Frediano Ziglio wrote:
> > >
> > > Hey,
> > >
> > > On Wed, Nov 23, 2016 at 06:07:25PM +, Frediano Ziglio wrote:
> > > > This patch is quite huge but have some benefits:
> > > > - reduce dependency (DummyChannel* and some RedChannelClient
> > > >
hramrach on IRC had an issue with audio not working. He was using
suse and his qemu defaulted to using the pulseaudio audio driver instead
of spice. Explicitly setting the audio driver to spice using the
QEMU_AUDIO_DRV environment variable solved the problem. Add this tip to
the manual for others
On 11/29/2016 06:54 PM, Jonathon Jongsma wrote:
hramrach on IRC had an issue with audio not working. He was using
suse and his qemu defaulted to using the pulseaudio audio driver instead
of spice. Explicitly setting the audio driver to spice using the
QEMU_AUDIO_DRV environment variable solved t
From: Victor Toso
Seems that usbredirhost initialization can take longer then
the channel_up call from spice-channel.
As this seems to be a race, a simple check for NULL pointer should be
enough. Similar fix was done in 5b252b0f499601bcf387c02a4dd35d27ed34c
#0 in usbredirhost_write_guest_data
Hi,
On Tue, Nov 29, 2016 at 11:10:40PM +0200, Uri Lublin wrote:
> On 11/29/2016 06:54 PM, Jonathon Jongsma wrote:
> > hramrach on IRC had an issue with audio not working. He was using
> > suse and his qemu defaulted to using the pulseaudio audio driver instead
> > of spice. Explicitly setting the
Hi,
On Tue, Nov 29, 2016 at 05:06:54PM +0200, Uri Lublin wrote:
> Also added "clients" to the sentence to make it clear
> that usbdk is to be installed on the client machine.
>
> Signed-off-by: Uri Lublin
Acked-by: Victor Toso
Both patches!
> ---
> spice-user-manual.asc | 6 +++---
> 1 file c
54 matches
Mail list logo
