From: Longguang Yue bigclo...@163.com
qxl-uxa was allocated twice, once in qxl_screen_init() and once in
qxl_uxa_init(). This commit removes the redundant allocation in
qxl_screen_init().
---
Here is a this same patch in git-format-patch format and with a whitespace
change removed. ACK from me
On Fri, Apr 04, 2014 at 11:40:33AM +0800, longguang.yue wrote:
have you decided ? i do not get your code from git.
You should be able to get it from git:
http://cgit.freedesktop.org/spice/spice-gtk/log/
Christophe
pgpRmwm3Q06RY.pgp
Description: PGP signature
The channel state is not synchronous.
It may happen that we want to set and unset quickly a modifier, but the
guest modifier state hasn't been updated yet, and will still be seen as
unset, preventing the last unset change.
---
gtk/spice-gtk-session.c | 10 +++---
1 file changed, 3
---
gtk/spice-gtk-session.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index fe77f47..644edcc 100644
--- a/gtk/spice-gtk-session.c
+++ b/gtk/spice-gtk-session.c
@@ -164,8 +164,8 @@ static void
nack, I am sending a better version,
On Fri, Apr 4, 2014 at 12:21 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
The channel state is not synchronous.
It may happen that we want to set and unset quickly a modifier, but the
guest modifier state hasn't been updated yet, and will
---
gtk/spice-gtk-session.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index fe77f47..922614d 100644
--- a/gtk/spice-gtk-session.c
+++ b/gtk/spice-gtk-session.c
@@ -41,6 +41,7 @@
#include spice-gtk-session-priv.h
The channel state is not synchronous.
It may happen that we want to set and unset quickly a modifier, but the
guest modifier state hasn't been updated yet, and will still be seen as
unset, preventing the last unset change.
---
gtk/spice-gtk-session.c | 19 +++
1 file changed, 11
Spice-GTK provides SPICE-specific command line options. This man page
describes these options as well as the format of SPICE URIs.
---
Makefile.am | 2 +-
man/spice-client.pod | 180 +++
2 files changed, 181 insertions(+), 1 deletion(-)
Spice-GTK provides SPICE-specific command line options. This man page
describes these options as well as the format of SPICE URIs.
---
Changes since v1:
- forgot to add man/Makefile.am + corresponding configure.ac change :)
Makefile.am | 2 +-
configure.ac | 1 +
ack
On Fri, Apr 4, 2014 at 2:46 PM, Christophe Fergeau cferg...@redhat.comwrote:
Spice-GTK provides SPICE-specific command line options. This man page
describes these options as well as the format of SPICE URIs.
---
Changes since v1:
- forgot to add man/Makefile.am + corresponding
pod2man -c spice-gtk documentation ?
On Fri, Apr 4, 2014 at 3:10 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
ack
On Fri, Apr 4, 2014 at 2:46 PM, Christophe Fergeau cferg...@redhat.comwrote:
Spice-GTK provides SPICE-specific command line options. This man page
describes these
Spice-GTK provides SPICE-specific command line options. This man page
describes these options as well as the format of SPICE URIs.
---
Changes since v2:
- added '-c' parameter to pod2man
- listed valid channel names in --spice-secure-channels description
- described USB filter syntax
Makefile.am
oops, I didn't really intend to commit that debug statement -- it makes the log
a bit noisy. Feel free to remove it if you'd like. Otherwise ACK.
- Original Message -
From: Marc-André Lureau marcandre.lur...@gmail.com
To: spice-devel@lists.freedesktop.org
Sent: Friday, April 4, 2014
sorry, I come for help again ==
fedora 19 x64
qemu from upstrem(2.0.0-rc1)
libvirt 1.2.3
spice-server 0.12.4
spice-protocol 0.12.6
According to http://elmarco.fedorapeople.org/manual.html#_configuration_7,
I configured xml with the following section:
channel type='spiceport'
source
On Fri, 2014-04-04 at 12:47 +0200, Marc-André Lureau wrote:
The channel state is not synchronous.
It may happen that we want to set and unset quickly a modifier, but the
guest modifier state hasn't been updated yet, and will still be seen as
unset, preventing the last unset change.
---
- Original Message -
- if the guest display widget is focused and the user presses
Caps lock, we will send a keypress message (which will cause the
capslock modifier to toggle on the guest) and then we will
immediately send a modifers message. So we'll
Just a couple minor nitpicks below. Otherwise ACK.
On Fri, 2014-04-04 at 15:23 +0200, Christophe Fergeau wrote:
Spice-GTK provides SPICE-specific command line options. This man page
describes these options as well as the format of SPICE URIs.
---
Changes since v2:
- added '-c' parameter to
Hi,
On Sat, Apr 5, 2014 at 12:23 AM, Marc-André Lureau mlur...@redhat.com wrote:
- Original Message -
sorry, I come for help again ==
fedora 19 x64
qemu from upstrem(2.0.0-rc1)
libvirt 1.2.3
spice-server 0.12.4
You'll also need spice-server from upstream git.
Yes, I rebuilt
- Original Message -
From: Marc-André Lureau mlur...@redhat.com
To: Jonathon Jongsma jjong...@redhat.com
Cc: spice-devel@lists.freedesktop.org
Sent: Friday, April 4, 2014 12:16:26 PM
Subject: Re: [Spice-devel] [PATCH spice-gtk 2/2] gtk-session: always sync
modifiers for client
ACK, but as you say, it's hard to tell if it will really fix that bug.
- Original Message -
From: Marc-André Lureau marcandre.lur...@gmail.com
To: spice-devel@lists.freedesktop.org
Sent: Friday, April 4, 2014 10:50:23 AM
Subject: [Spice-devel] [PATCH spice-gtk] display: signal
20 matches
Mail list logo
