[Spice-devel] [PATCH] [spice-gtk] keyboard: wrong defined macro for WIN32

2014-08-13 Thread Cody Chan
On windows client, there's no effect for guest when enabling CAPS_LOCK/NUM_LOCK/SCROLL_LOCK on (because of the delay, guest may take the effect for several seconds). There's a wrong defined macro, then modifiers is ALWAYS 0, and the keyboard state of guest is synchronized with the state client by

Re: [Spice-devel] [PATCH] [spice-gtk] keyboard: wrong defined macro for WIN32

2014-08-13 Thread Marc-André Lureau
Hi - Original Message - On windows client, there's no effect for guest when enabling CAPS_LOCK/NUM_LOCK/SCROLL_LOCK on (because of the delay, guest may take the effect for several seconds). There's a wrong defined macro, then modifiers is ALWAYS 0, and the keyboard state of guest is

Re: [Spice-devel] [PATCH] [spice-gtk] keyboard: wrong defined macro for WIN32

2014-08-13 Thread Cody Chan
Yeah, I have tracked the commit log, and the reconstruction of this part is a good job of Jonathon ^_^ On Wed, Aug 13, 2014 at 4:57 PM, Marc-André Lureau mlur...@redhat.com wrote: Hi - Original Message - On windows client, there's no effect for guest when enabling

Re: [Spice-devel] [PATCH v2 1/2] Ensure keyboard modifiers are synchronized properly

2014-08-13 Thread Marc-André Lureau
Hi, I just noticed spice_gtk_session_sync_keyboard_modifiers() is not actually exported, and not documented etc. Imho, it's not really helping to put in public API, I would rather move declaration to spice-gtk-session-priv.h. What do you think? On Thu, Apr 3, 2014 at 12:38 AM, Marc-André

[Spice-devel] spice with qxl on xen linux domU's, probably problem with sse2 instrutions and/or other unknow things

2014-08-13 Thread Fabio Fantoni
For 2 years or more I'm trying to get spice full features fully working with xen but I found a qxl problem with linux domUs that I'm unable to debug. With the last tests I was able to see a backtrace in the xorg log (though perhaps not track the direct cause) and a different behavior with a

[Spice-devel] [spice-gtk] Use G_OS_WIN32 #define everywhere

2014-08-13 Thread Christophe Fergeau
Currently some parts of the windows specific code is checking for the WIN32 define, and other parts are checking G_OS_WIN32. This commit uses G_OS_WIN32 everywhere for consistency. --- gtk/channel-display.c | 8 gtk/decode-jpeg.c | 2 +- gtk/spice-gtk-session.c | 6 --

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters in name

2014-08-13 Thread Christophe Fergeau
On Tue, Aug 12, 2014 at 06:52:00PM +0800, Cody Chan wrote: ​ I submitted a patch several months ago about this issue, here http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html I check it again, and find that the value of g_key_file_to_data(keyfile,...) is always

[Spice-devel] [PATCH] spice_gtk_session_sync_keyboard_modifiers() is internal

2014-08-13 Thread Jonathon Jongsma
This function was not exported, and it's not really useful as public API, so move the declaration to the private header. --- gtk/spice-gtk-session-priv.h | 1 + gtk/spice-gtk-session.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/spice-gtk-session-priv.h

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-13 Thread Christophe Fergeau
Hi Cody, On Tue, Aug 12, 2014 at 11:40:58AM +0200, Christophe Fergeau wrote: On Mon, Aug 11, 2014 at 07:58:44PM +0800, Cody Chan wrote: ​ I submitted a patch several months ago about this issue, here http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html I check

Re: [Spice-devel] [PATCH] spice_gtk_session_sync_keyboard_modifiers() is internal

2014-08-13 Thread Fabiano Fidêncio
Hey! On Wed, Aug 13, 2014 at 4:21 PM, Jonathon Jongsma jjong...@redhat.com wrote: This function was not exported, and it's not really useful as public API, so move the declaration to the private header. --- gtk/spice-gtk-session-priv.h | 1 + gtk/spice-gtk-session.h | 1 - 2 files

Re: [Spice-devel] [spice-gtk] Use G_OS_WIN32 #define everywhere

2014-08-13 Thread Jonathon Jongsma
Sounds good to me. ACK. On Wed, 2014-08-13 at 16:13 +0200, Christophe Fergeau wrote: Currently some parts of the windows specific code is checking for the WIN32 define, and other parts are checking G_OS_WIN32. This commit uses G_OS_WIN32 everywhere for consistency. ---

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-13 Thread Cody Chan
The attach is the patch​. On Wed, Aug 13, 2014 at 10:47 PM, Cody Chan int64...@gmail.com wrote: But you ACKed this: http://lists.freedesktop.org/archives/spice-devel/2014-August/017209.html and this's my final version, doesn't it work? On Wed, Aug 13, 2014 at 10:27 PM, Christophe Fergeau

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-13 Thread Christophe Fergeau
On Wed, Aug 13, 2014 at 10:47:14PM +0800, Cody Chan wrote: But you ACKed this: http://lists.freedesktop.org/archives/spice-devel/2014-August/017209.html and this's my final version, doesn't it work? Since you said you tested this patch and it works for you, I'm trusting your tests, I haven't

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-13 Thread Cody Chan
On Wed, Aug 13, 2014 at 11:13 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Aug 13, 2014 at 10:47:14PM +0800, Cody Chan wrote: But you ACKed this: http://lists.freedesktop.org/archives/spice-devel/2014-August/017209.html and this's my final version, ​​ doesn't it work?

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-13 Thread Christophe Fergeau
On Wed, Aug 13, 2014 at 11:21:11PM +0800, Cody Chan wrote: On Wed, Aug 13, 2014 at 11:13 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Aug 13, 2014 at 10:47:14PM +0800, Cody Chan wrote: But you ACKed this:

[Spice-devel] [spice-gtk] Fix 'loose' typo

2014-08-13 Thread Christophe Fergeau
--- Hey, I've pushed this already as this is a trivial change. Christophe gtk/channel-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 7a299a4..f33b0fd 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c @@

Re: [Spice-devel] spice related qemu crash

2014-08-13 Thread David Mansfield
On 08/12/2014 05:10 AM, Christophe Fergeau wrote: On Mon, Aug 11, 2014 at 03:34:07PM -0400, David Mansfield wrote: Hi All, I have a qemu 1.6.2 (SRPM from F20 recompiled on Centos 7) which crashed with the following in the qemu log. Not sure exactly what the timing of the messages are here,