Current error message in SPICE-HTML5 error is poor (error-logging function
prints error.toString() which doesn't contain anything detailed).
This patch enhances this message in the following way:
- error event contains target attribute ([1]),
- the code in this patch checks for presence of
On Thu, Oct 30, 2014 at 10:35:15AM +0100, Frantisek Kobzik wrote:
Current error message in SPICE-HTML5 error is poor (error-logging function
prints error.toString() which doesn't contain anything detailed).
This patch enhances this message in the following way:
- error event contains target
Yeah, I know about this.
The thing is that error is logged anyway using this.parent.report_log on the
next line. I didn't want to duplicate the (useless) information in the debug
div.
But I can change the patch so that it prints the error the old way and concats
it with my message which is a
On Thu, Oct 30, 2014 at 06:35:36AM -0400, Frantisek Kobzik wrote:
Yeah, I know about this.
The thing is that error is logged anyway using this.parent.report_log
on the next line. I didn't want to duplicate the (useless) information
in the debug div.
Yeah, I've noticed the report_log() call.
---
tests/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 6f80d93..b236b12 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -20,3 +20,5 @@ LDADD =
\
util_SOURCES =
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index 2eb4488..f7fdf30 100644
--- a/.mailmap
+++ b/.mailmap
@@ -5,3 +5,4 @@
cferg...@redhat.com cferg...@gmail.com
marcandre.lur...@redhat.com marcandre.lur...@gmail.com
Tiziano Müller
- disable-static: it's quite uncommon to use static build of gtk libraries
- win32-dll: the shared libs build cleanly for win32 already
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f47ee20..0d65823 100644
--- a/configure.ac
Pushed unreviewed as trivial cleanups.
Marc-André Lureau (4):
build-sys: change default libtool options
build-sys: generate gitignore in tests dir
build-sys: add some missing MAINTAINERCLEANFILES
mailmap: add Dietmar Maurer
.mailmap | 1 +
Makefile.am | 2 ++
configure.ac
---
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.am b/Makefile.am
index 5029497..8ac2028 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -56,6 +56,7 @@ MAINTAINERCLEANFILES =\
m4/ltsugar.m4 \
---
gtk/channel-usbredir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c
index a52476a..5238566 100644
--- a/gtk/channel-usbredir.c
+++ b/gtk/channel-usbredir.c
@@ -1,6 +1,6 @@
/* -*- Mode: C; c-basic-offset: 4;
---
TODO | 1 -
doc/reference/spice-gtk.types | 2 +-
gtk/controller/dump.c | 1 -
gtk/controller/namedpipelistener.h | 1 -
gtk/controller/spice-controller-listener.h | 3 ---
gtk/controller/util.vala
---
configure.ac | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/configure.ac b/configure.ac
index c2faedc..8bec7a1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -285,7 +285,7 @@ else
fi
fi
AS_IF([test x$have_phodav = xyes],
-
They are not portable, it's recommended to use test test or test ||
test instead
---
configure.ac | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index f47ee20..c2faedc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -121,7 +121,7 @@
Some source files inconsistently use space VS tabs. Most of the codebase
uses 8 spaces for indentation, this commit changes the remaining tabs to
spaces.
---
gtk/channel-display.h| 2 +-
gtk/channel-main.c | 14 +-
gtk/channel-record.h | 2 +-
const guint16 const * has one extra 'const' which is removed by that
commit
---
gtk/spice-widget-priv.h | 2 +-
gtk/vncdisplaykeymap.c | 6 +++---
gtk/vncdisplaykeymap.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h
---
gtk/decode-glz-tmpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/decode-glz-tmpl.c b/gtk/decode-glz-tmpl.c
index ab09bba..b337a8b 100644
--- a/gtk/decode-glz-tmpl.c
+++ b/gtk/decode-glz-tmpl.c
@@ -133,7 +133,7 @@
out-b = (out-b 3) | ((out-b 2) 0x07);
gnulib 'make syntax-check' prohibits use of #ifdef HAVE_CONFIG_H so this
commit removes it from where it's used. It also makes sure we always use
the same syntax for including config.h (#include config.h VS #include
config.h) as a consistent way of doing that is expected.
---
Hey,
libvirt and various related projects have a make syntax-check rule which makes
various static check on the source files regarding indentation, formatting,
common coding mistakes, ...
I wanted to add a check that spice-gtk map-file are alphabetically sorted
and mistakenly though that we would
This is copied and pasted from gnulib, and adds a bunch of static checks
on the format/content of the source files being used. Running make
syntax-check will trigger these checks, and error out if one fails.
cfg.mk can be used to tweak the behaviour of some tests (eg exclude some
files).
---
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
They are not portable, it's recommended to use test test or test ||
test instead
---
configure.ac | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
In general, I am against this kind of cleanups which make git blame harder
to use, but here it is small enough, so why not?
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
---
TODO | 1 -
doc/reference/spice-gtk.types
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
---
configure.ac | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/configure.ac b/configure.ac
index c2faedc..8bec7a1 100644
--- a/configure.ac
+++
Quoting GNU maintainer manual:
https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
Alternatively, the ‘(C)’ or C-in-a-circle can be omitted entirely; the
word ‘Copyright’ suffices.
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
---
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
const guint16 const * has one extra 'const' which is removed by that
commit
---
gtk/spice-widget-priv.h | 2 +-
gtk/vncdisplaykeymap.c | 6 +++---
gtk/vncdisplaykeymap.h | 4 ++--
3 files changed, 6
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
They were never translated from .in files to actual files, and now it's
clear we don't want to promote spicy as a first-class desktop
application.
---
configure.ac | 1 -
data/Makefile.am
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
---
gtk/usb-device-widget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/usb-device-widget.c b/gtk/usb-device-widget.c
index 69c74b3..74862ee 100644
--- a/gtk/usb-device-widget.c
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
gnulib 'make syntax-check' prohibits use of #ifdef HAVE_CONFIG_H so this
commit removes it from where it's used. It also makes sure we always use
the same syntax for including config.h (#include config.h VS
On Thu, Oct 30, 2014 at 1:59 PM, Marc-André Lureau
marcandre.lur...@gmail.com wrote:
In general, I am against this kind of cleanups which make git blame harder
to use, but here it is small enough, so why not?
ok this patch is actually just removing lines (I thought it was also
trailing
ack
On Thu, Oct 30, 2014 at 1:56 PM, Christophe Fergeau cferg...@redhat.com
wrote:
---
gtk/decode-glz-tmpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/decode-glz-tmpl.c b/gtk/decode-glz-tmpl.c
index ab09bba..b337a8b 100644
--- a/gtk/decode-glz-tmpl.c
+++
On Thu, Oct 30, 2014 at 02:08:32PM +0100, Marc-André Lureau wrote:
I would rather not do that massive tab cleanup, because it is a pain in
reading history with git blame.
Well, it's a one off pain as then new tabs should not be introduced,
and this just adds one extra step when using git
On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote:
Quoting GNU maintainer manual:
https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
Alternatively, the ‘(C)’ or C-in-a-circle can be omitted entirely; the
word ‘Copyright’ suffices.
The rule which asks for that
On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote:
Quoting GNU maintainer manual:
https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
Alternatively, the ‘(C)’ or C-in-a-circle
On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote:
Quoting GNU maintainer manual:
On Thu, Oct 30, 2014 at 01:38:26PM +, Daniel P. Berrange wrote:
On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote:
On Thu, Oct 30, 2014 at 02:55:05PM +0100, Christophe Fergeau wrote:
On Thu, Oct 30, 2014 at 01:38:26PM +, Daniel P. Berrange wrote:
On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau cferg...@redhat.com
wrote:
On Thu, Oct 30, 2014 at 02:27:48PM +, Daniel P. Berrange wrote:
On Thu, Oct 30, 2014 at 02:55:05PM +0100, Christophe Fergeau wrote:
On Thu, Oct 30, 2014 at 01:38:26PM +, Daniel P. Berrange wrote:
On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
On Thu, Oct 30,
ack as well, seems like a nice change.
Cheers,
Jeremy
On 10/30/2014 04:35 AM, Frantisek Kobzik wrote:
Current error message in SPICE-HTML5 error is poor (error-logging function
prints error.toString() which doesn't contain anything detailed).
This patch enhances this message in the following
From: Christophe Fergeau cferg...@redhat.com
This commit adds GStreamer 1.0 support.
To enable GStreamer 1.0: --with-audio=gstreamer1
There is only a few changes between those versions, worth mentioning:
- audio capabilities audio/x-raw,format=... instead of
audio/x-raw-int,...
- appsink
On 10/30/2014 06:39 PM, vtoso...@redhat.com wrote:
From: Christophe Fergeau cferg...@redhat.com
This commit adds GStreamer 1.0 support.
To enable GStreamer 1.0: --with-audio=gstreamer1
commit first line should say audio somewhere.
There is only a few changes between those versions, worth
On Thu, Oct 30, 2014 at 5:53 PM, Christophe Fergau
t...@kemper.freedesktop.org wrote:
commit 20316442a5f80fc475543ceb79cdee98907dba61
Author: Christophe Fergeau cferg...@redhat.com
Date: Wed Oct 29 17:07:43 2014 +0100
Add missing (C) to Red Hat copyright line
gnulib's make
With el6 now shipping glib 2.28, there is no very good reason to keep
support for older glib versions alive, especially as it will barely be
tested.
---
configure.ac | 16 ++---
gtk/Makefile.am | 9 ++---
gtk/bio-gio.c | 26 ++
gtk/bio-gio.h
- Original Message -
With el6 now shipping glib 2.28, there is no very good reason to keep
support for older glib versions alive, especially as it will barely be
tested.
---
configure.ac | 16 ++---
gtk/Makefile.am | 9 ++---
gtk/bio-gio.c
On Thu, Oct 30, 2014 at 01:10:05PM -0400, Marc-André Lureau wrote:
- Original Message -
With el6 now shipping glib 2.28, there is no very good reason to keep
support for older glib versions alive, especially as it will barely be
tested.
---
configure.ac | 16
43 matches
Mail list logo
