Re: [Spice-devel] [spice-gtk 08/13] usb-redir: change signal prototype of win-usb-dev

2019-03-13 Thread Yuri Benditovich
On Tue, Mar 12, 2019 at 4:02 PM Christophe Fergeau wrote: > > On Sun, Mar 10, 2019 at 04:46:07PM +0200, Yuri Benditovich wrote: > > Changing signal definition from (boxed-boxed) to (pointer,int). > > There is no need for additional referencing of GUdevDevice > > object before signal callback. > >

Re: [Spice-devel] [spice-gtk 12/13] usb-redir: use persistent libusb_device under Windows also

2019-03-13 Thread Christophe Fergeau
On Wed, Mar 13, 2019 at 10:38:09AM +0200, Yuri Benditovich wrote: > On Tue, Mar 12, 2019 at 7:31 PM Christophe Fergeau > wrote: > > > > On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote: > > > Unify SpiceUsbDeviceInfo for Linux and Windows by using > > > persistent libusb_device.

Re: [Spice-devel] [PATCH spice-common] test-ssl-verify: Improve subject_to_x509_name coverage

2019-03-13 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Mar 13, 2019 at 12:20:22PM +, Frediano Ziglio wrote: > Check that attempting to quote an invalid character result in > a error. > > Signed-off-by: Frediano Ziglio > --- > tests/test-ssl-verify.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Spice-devel] [PATCH spice-protocol] protocol: Generate enums.h again to remove old protocol definitions

2019-03-13 Thread Frediano Ziglio
ping > > spice.proto was updated to remove really old definitions, > update enums.h accordingly. > > Signed-off-by: Frediano Ziglio > --- > spice/enums.h | 57 --- > 1 file changed, 57 deletions(-) > > diff --git a/spice/enums.h b/spice/enums.h

[Spice-devel] [PATCH spice-common] test-ssl-verify: Improve subject_to_x509_name coverage

2019-03-13 Thread Frediano Ziglio
Check that attempting to quote an invalid character result in a error. Signed-off-by: Frediano Ziglio --- tests/test-ssl-verify.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-ssl-verify.c b/tests/test-ssl-verify.c index e307e3f..f5c5881 100644 --- a/tests/test-ssl-verify.c +++

Re: [Spice-devel] [spice-gtk 12/13] usb-redir: use persistent libusb_device under Windows also

2019-03-13 Thread Yuri Benditovich
On Tue, Mar 12, 2019 at 7:31 PM Christophe Fergeau wrote: > > On Sun, Mar 10, 2019 at 04:46:11PM +0200, Yuri Benditovich wrote: > > Unify SpiceUsbDeviceInfo for Linux and Windows by using > > persistent libusb_device. > > This really needs to be more detailed and explain why this is no longer > a

Re: [Spice-devel] [spice-gtk 10/13] win-usb-dev: maintain list of libusb devices

2019-03-13 Thread Christophe Fergeau
On Wed, Mar 13, 2019 at 09:36:06AM +0200, Yuri Benditovich wrote: > On Tue, Mar 12, 2019 at 7:22 PM Christophe Fergeau > wrote: > > > > On Sun, Mar 10, 2019 at 04:46:09PM +0200, Yuri Benditovich wrote: > > > Change internal device list to maintain libusb devices > > > instead of GUdevDevice

Re: [Spice-devel] [spice-gtk 02/13] usb-redir: remove unused 'subsystem' parameter

2019-03-13 Thread Christophe Fergeau
On Wed, Mar 13, 2019 at 09:49:19AM +0200, Yuri Benditovich wrote: > On Mon, Mar 11, 2019 at 7:07 PM Christophe Fergeau > wrote: > > > > On Sun, Mar 10, 2019 at 04:46:01PM +0200, Yuri Benditovich wrote: > > > Removing unused parameter for GUdevClient constructor. > > > > I'd explicitly mention

Re: [Spice-devel] [spice-gtk 09/13] win-usb-dev: do not allocate memory for hub devices

2019-03-13 Thread Yuri Benditovich
On Tue, Mar 12, 2019 at 4:11 PM Christophe Fergeau wrote: > > On Sun, Mar 10, 2019 at 04:46:08PM +0200, Yuri Benditovich wrote: > > When processing list of USB devices, avoid allocating memory > > for devices which later will be skipped. Use existing libusb > > struct first to check whether the

Re: [Spice-devel] [spice-gtk 04/13] usb-redir: do not add device if one with the same bus:addr exists

2019-03-13 Thread Christophe Fergeau
On Wed, Mar 13, 2019 at 09:40:14AM +0200, Yuri Benditovich wrote: > On Mon, Mar 11, 2019 at 7:17 PM Christophe Fergeau > wrote: > > > > On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote: > > > In initial device enumeration hotplug notification can be > > > called twice with the

Re: [Spice-devel] [spice-gtk 04/13] usb-redir: do not add device if one with the same bus:addr exists

2019-03-13 Thread Yuri Benditovich
On Mon, Mar 11, 2019 at 7:17 PM Christophe Fergeau wrote: > > On Sun, Mar 10, 2019 at 04:46:03PM +0200, Yuri Benditovich wrote: > > In initial device enumeration hotplug notification can be > > called twice with the same libusb device. For details, see > >

Re: [Spice-devel] [spice-gtk 10/13] win-usb-dev: maintain list of libusb devices

2019-03-13 Thread Yuri Benditovich
On Tue, Mar 12, 2019 at 7:22 PM Christophe Fergeau wrote: > > On Sun, Mar 10, 2019 at 04:46:09PM +0200, Yuri Benditovich wrote: > > Change internal device list to maintain libusb devices > > instead of GUdevDevice objects. Create temporary > > GUdevDevice object only for indication to