Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

2019-03-27 Thread Frediano Ziglio
> Hi > > On Wed, Mar 27, 2019 at 8:23 AM Frediano Ziglio wrote: > > > > > > > > From: Marc-André Lureau > > > > > > When this capability is negoticated by both the client & the agent, > > > > negotiated > > > > > the clipboard grab messages have an associated serial counter. > > > > > > The

Re: [Spice-devel] [spice-gtk 2/2] win-usb-dev: Use 'stable' libusb_device pointers in GUdevClient::udev_list

2019-03-27 Thread Christophe Fergeau
Hey, On Wed, Mar 27, 2019 at 10:48:45AM +0200, Yuri Benditovich wrote: > On Tue, Mar 26, 2019 at 3:11 PM Christophe Fergeau > wrote: > > > > On Mon, Mar 25, 2019 at 08:03:05PM +0200, Yuri Benditovich wrote: > > > Yes, it looks like this finally does the same thing. > > > > > From my personal

Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

2019-03-27 Thread Marc-André Lureau
Hi On Wed, Mar 27, 2019 at 8:23 AM Frediano Ziglio wrote: > > > > > From: Marc-André Lureau > > > > When this capability is negoticated by both the client & the agent, > > negotiated > > > the clipboard grab messages have an associated serial counter. > > > > The serial is reset to 0 upon

Re: [Spice-devel] [spice-gtk 2/2] win-usb-dev: Use 'stable' libusb_device pointers in GUdevClient::udev_list

2019-03-27 Thread Yuri Benditovich
On Tue, Mar 26, 2019 at 3:11 PM Christophe Fergeau wrote: > > On Mon, Mar 25, 2019 at 08:03:05PM +0200, Yuri Benditovich wrote: > > Yes, it looks like this finally does the same thing. > > > From my personal point of view, this is less obvious than previous > > code, so I would add 2 comments: >

Re: [Spice-devel] [PATCH spice-server 1/2] docs: Fix typo

2019-03-27 Thread Uri Lublin
On 3/27/19 10:25 AM, Frediano Ziglio wrote: On Mon, Mar 18, 2019 at 09:44:59AM -0400, Frediano Ziglio wrote: -Lots of code run in a single thread. +Lots of code runs in a single thread. "Lots of" is plural, isn't it? Maybe "A lot of code runs .." Christophe You are right. Which one is

Re: [Spice-devel] [PATCH spice-server 1/2] docs: Fix typo

2019-03-27 Thread Frediano Ziglio
> On Mon, Mar 18, 2019 at 09:44:59AM -0400, Frediano Ziglio wrote: > > > > -Lots of code run in a single thread. > > > > +Lots of code runs in a single thread. > > > > > > "Lots of" is plural, isn't it? Maybe "A lot of code runs .." > > > > > > Christophe > > > > > > > You are right. Which one

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-27 Thread Frediano Ziglio
ping > > > > On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > > > ping > > > > > > > > > > > RedClient was an opaque structure for RedCharDevice. > > > > It started to be used when RedsState started to contain all > > > > the global state. > > > > Make it opaque again. > > >

Re: [Spice-devel] [PATCH spice-protocol] protocol: Generate enums.h again to remove old protocol definitions

2019-03-27 Thread Frediano Ziglio
ping > > > > This is breaking spice-protocol API even if this should not impact > > current code. Do we want to advertise this somehow? Switch to > > spice-protocol 0.14.x? > > > > Fine for me both 0.14.0 or 0.12.16 (the future, current HEAD version) > > > On Fri, Feb 22, 2019 at 12:16:52PM

Re: [Spice-devel] [PATCH spice-protocol 3/3] vdagent: introduce VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL

2019-03-27 Thread Frediano Ziglio
> > From: Marc-André Lureau > > When this capability is negoticated by both the client & the agent, negotiated > the clipboard grab messages have an associated serial counter. > > The serial is reset to 0 upon client connection. > > The counter is increment by 1 on each grab message, by