Implement on_disconnect_mig_src and on_connect_mig_target in order to avoid
unnecessary cleanups done in on_(disconnet|connect).
In addition, do not request guest display settings changes after migration.
Signed-off-by: Yonit Halperin
---
client/red_client.cpp | 37
Signed-off-by: Yonit Halperin
---
client/audio_channels.h | 12 ++--
client/playback_channel.cpp | 22 --
client/record_channel.cpp | 39 ---
3 files changed, 54 insertions(+), 19 deletions(-)
diff --git a/client
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 158
client/display_channel.h | 12 +++-
client/red_gl_canvas.cpp |1 +
3 files changed, 155 insertions(+), 16 deletions(-)
diff --git a/client/display_channel.cpp b/client
Fix not destroying surfaces and other data (e.g., streams) upon disconnection.
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 18 --
client/display_channel.h |1 +
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/client/display_channel.cpp
cb will be called after spice client has been
connected to the target (or a timeout). See following patches and spice patches.
Signed-off-by: Yonit Halperin
---
hmp-commands.hx |3 ++-
monitor.c |6 --
qmp-commands.hx |3 ++-
ui/qemu-spice.h | 13 +++--
ui/spice
- call spice_server_migrate_(start|end).
- register client_migrate_info completion callback
Signed-off-by: Yonit Halperin
---
ui/spice-core.c | 54 +-
1 files changed, 53 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice
semi-seamless migration RHBZ 738262
Signed-off-by: Yonit Halperin
---
NEWS |4
configure.ac |2 +-
spice/enums.h|2 ++
spice/protocol.h |6 +-
4 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index f238abc..bb11ed2 100644
ess noticable to the user.
On 09/19/2011 12:46 PM, Yonit Halperin wrote:
Here is a summary of the new migration scheme (copied from the commit msg of
the first patch)
migration source side
-
(1) spice_server_migrate_info (*): tell client to link
to
On 09/19/2011 03:18 PM, Gerd Hoffmann wrote:
On 09/19/11 11:46, Yonit Halperin wrote:
Signed-off-by: Yonit Halperin
What happens on connect timeouts?
immediately upon client_migrate_info I start a timer of 10 secs. If it
timeouts before the connection is completed I call the async command
On 09/19/2011 03:15 PM, Gerd Hoffmann wrote:
On 09/19/11 11:46, Yonit Halperin wrote:
semi-seamless migration details:
migration source side
-
(1) spice_server_migrate_info (*): tell client to link
to the target side - send SPICE_MSG_MAIN_MIGRATE_BEGIN.
client_migrate_info
On 09/19/2011 05:26 PM, Christophe Fergeau wrote:
When running some xinerama tests, I got several
glz_usr_free_image: error
messages. Looking at the code, this error is reported when this
function is called from a different DisplayChannelClient than the
one which created the glz compressed image.
On 09/19/2011 04:24 PM, Alon Levy wrote:
On Mon, Sep 19, 2011 at 04:06:25PM +0300, Yonit Halperin wrote:
On 09/19/2011 03:15 PM, Gerd Hoffmann wrote:
On 09/19/11 11:46, Yonit Halperin wrote:
semi-seamless migration details:
migration source side
-
(1
On 09/19/2011 07:13 PM, Gerd Hoffmann wrote:
Hi,
We need to handle another case: New client. New source server. Old
target server.
Indeed.
2. When client connects to the server it sees that the server doesn't
have the SEMI_SEAMLESS_CAP present. So it disconnects, and sends to
the source a
On 09/20/2011 03:44 PM, Alon Levy wrote:
On Mon, Sep 19, 2011 at 12:47:07PM +0300, Yonit Halperin wrote:
RHBZ 725009, 738270
Signed-off-by: Yonit Halperin
---
client/red_client.cpp | 19 ---
1 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/client
On 09/20/2011 07:12 PM, Alon Levy wrote:
On Mon, Sep 19, 2011 at 12:47:11PM +0300, Yonit Halperin wrote:
Some nitpicks. One question on the added touch_context at the end.
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 158
On 09/19/2011 03:21 PM, Gerd Hoffmann wrote:
Hi,
diff --git a/spice.proto b/spice.proto
index 6160de1..d5b954e 100644
--- a/spice.proto
+++ b/spice.proto
@@ -167,9 +167,8 @@ channel MainChannel : BaseChannel {
uint16 sport;
uint32 host_size;
uint8 *host_data[host_size] @zero_terminated @marshal
we implement a real seamless spice migration
Spice server patches will be emailed next. They are for the 0.8 spice branch,
but will be ported to upstream soon.
Yonit Halperin (2):
spice: turn client_migrate_info to async
spice: support the new migration interface (spice 0.8.3)
hmp-commands
cb will be called after spice client has been
connected to the target (or a timeout). See following patches and spice patches.
Signed-off-by: Yonit Halperin
---
hmp-commands.hx |3 ++-
monitor.c |6 --
qmp-commands.hx |3 ++-
ui/qemu-spice.h | 13 +++--
ui/spice
- call spice_server_migrate_(start|end|connect).
- register spice_migrate_connect completion callback
Signed-off-by: Yonit Halperin
---
ui/spice-core.c | 56 ++-
1 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c
not accept
new spice client
connections. Thus, we trigger the connection to the target upon
client_migrate_info
command.
Yonit Halperin (13):
server/spice.h: semi-seamless migration interface, RHBZ #738266
server: handle migration interface addition
configure: spice-protocol >=
_migrate_info
command.
Signed-off-by: Yonit Halperin
---
server/reds.c |9 +
server/spice-experimental.h |3 ---
server/spice.h | 27 ++-
3 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server
Signed-off-by: Yonit Halperin
---
server/reds.c | 29 +
server/reds.h |4
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 9a983f8..99d52f9 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -73,6 +73,7
Signed-off-by: Yonit Halperin
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3a86515..e169f36 100644
--- a/configure.ac
+++ b/configure.ac
@@ -126,7 +126,7 @@ fi
dnl
(1) send SPICE_MSG_MAIN_MIGRATE_BEGIN upon spice_server_migrate_connect
(2) wait for SPICE_MSGC_MAIN_MIGRATE_(CONNECTED|CONNECT_ERROR), or a timeout,
in order
to complete client_migrate_info monitor command
Signed-off-by: Yonit Halperin
---
common/messages.h |2 +
server/reds.c
Signed-off-by: Yonit Halperin
---
spice.proto |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index d5b954e..235ec95 100644
--- a/spice.proto
+++ b/spice.proto
@@ -219,6 +219,8 @@ channel MainChannel : BaseChannel {
uint8
Signed-off-by: Yonit Halperin
---
server/reds.c | 86 +
1 files changed, 68 insertions(+), 18 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 845b0ee..e088b08 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -275,6 +275,7
Signed-off-by: Yonit Halperin
---
server/reds.c | 56 +---
1 files changed, 33 insertions(+), 23 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index e088b08..bea0eb0 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2078,6
Signed-off-by: Yonit Halperin
---
server/reds.c | 68 +++-
1 files changed, 42 insertions(+), 26 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index bea0eb0..e7388a0 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2612,12
(1) not sending anything to the client till we recieve SPICE_MSGC_MIGRATE_END
(2) start a new migration (handle client_migrate_info) only after
SPICE_MSGC_MIGRATE_END
from the previous migration has been received
(3) use the correct ticket
Signed-off-by: Yonit Halperin
---
server/reds.c
Signed-off-by: Yonit Halperin
---
server/reds.c | 72 ++---
1 files changed, 43 insertions(+), 29 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index ca4e1d1..6d2269c 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -761,6 +761,7
We will add a qemu call to spice_server_migrate_start when migration starts.
For now, it does nothing, but we may need this notification in the future.
Signed-off-by: Yonit Halperin
---
server/reds.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/server/reds.c b
Signed-off-by: Yonit Halperin
---
server/reds.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 76aa0ed..54c06d1 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -283,6 +283,7 @@ typedef struct RedsState {
int
Signed-off-by: Yonit Halperin
---
NEWS |7 +++
configure.ac |2 +-
server/spice-server.syms |4
server/spice.h |2 +-
4 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index ee6ceec..18168cb 100644
semi-seamless migration RHBZ 738262
Signed-off-by: Yonit Halperin
---
NEWS |4
configure.ac |2 +-
spice/enums.h|2 ++
spice/protocol.h |6 +-
4 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index f238abc..bb11ed2 100644
On 09/22/2011 05:01 PM, Alon Levy wrote:
On Wed, Sep 21, 2011 at 06:51:18PM +0300, Yonit Halperin wrote:
Signed-off-by: Yonit Halperin
---
server/reds.c | 68 +++-
1 files changed, 42 insertions(+), 26 deletions(-)
diff --git a/server
ct_mig_src/on_channel_disconnect_mig_src_completed
* client: rearrange RedClient::handle_init
* server, client: fix whitespace, typos, etc.
* client: support migration between spice servers with different protocols. Not
needed right now, but maybe in the future it will be.
Cheers,
Yonit.
Yonit Halperin (22):
serv
_migrate_info
command.
Signed-off-by: Yonit Halperin
---
server/reds.c |9 +
server/spice-experimental.h |3 ---
server/spice.h | 27 ++-
3 files changed, 35 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server
Signed-off-by: Yonit Halperin
---
server/reds.c | 29 +
server/reds.h |4
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 9a983f8..99d52f9 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -73,6 +73,7
Signed-off-by: Yonit Halperin
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3a86515..e169f36 100644
--- a/configure.ac
+++ b/configure.ac
@@ -126,7 +126,7 @@ fi
dnl
(1) send SPICE_MSG_MAIN_MIGRATE_BEGIN upon spice_server_migrate_connect
(2) wait for SPICE_MSGC_MAIN_MIGRATE_(CONNECTED|CONNECT_ERROR), or a timeout,
in order
to complete client_migrate_info monitor command
Signed-off-by: Yonit Halperin
---
common/messages.h |2 +
server/reds.c
Signed-off-by: Yonit Halperin
---
spice.proto |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index d5b954e..235ec95 100644
--- a/spice.proto
+++ b/spice.proto
@@ -219,6 +219,8 @@ channel MainChannel : BaseChannel {
uint8
Signed-off-by: Yonit Halperin
---
server/reds.c | 85 +
1 files changed, 67 insertions(+), 18 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 845b0ee..4ffdfb2 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -275,6 +275,7
Signed-off-by: Yonit Halperin
---
server/reds.c | 56 +---
1 files changed, 33 insertions(+), 23 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 4ffdfb2..8ed84a8 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2078,6
Signed-off-by: Yonit Halperin
---
server/reds.c | 67 ++--
1 files changed, 41 insertions(+), 26 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 8ed84a8..6e7b891 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2612,12
and ater migration. i.e.,
SPICE_MSGC_MAIN_ATTACH_CHANNELS is not sent from the client.
Signed-off-by: Yonit Halperin
---
server/reds.c | 136
1 files changed, 116 insertions(+), 20 deletions(-)
diff --git a/server/reds.c b/server/reds.c
Signed-off-by: Yonit Halperin
---
server/reds.c | 72 ++---
1 files changed, 43 insertions(+), 29 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 0f67a95..e61751d 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -761,6 +761,7
We will add a qemu call to spice_server_migrate_start when migration starts.
For now, it does nothing, but we may need this notification in the future.
Signed-off-by: Yonit Halperin
---
server/reds.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/server/reds.c b
Signed-off-by: Yonit Halperin
---
server/reds.c | 26 +-
1 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 8ee002f..10d2ffc 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -283,6 +283,7 @@ typedef struct RedsState
use std::map instead of a specific template (CHash).
There is no need for special template. Moreover, using
std::map will allow easy iteration over the surfaces.
Signed-off-by: Yonit Halperin
---
client/canvas.cpp | 25 +++-
client/canvas.h| 152
Signed-off-by: Yonit Halperin
---
client/application.cpp | 57 ++--
client/red_peer.cpp| 51 ++
client/red_peer.h |2 +-
3 files changed, 59 insertions(+), 51 deletions(-)
diff --git a/client
RHBZ 725009, 738270
Signed-off-by: Yonit Halperin
---
client/red_client.cpp | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/client/red_client.cpp b/client/red_client.cpp
index d7a3e6a..f09e3c9 100644
--- a/client/red_client.cpp
+++ b/client
(1) disconnect all channels from the migration src
(2) after all channels are disconnected, clean global resources
(3) send SPICE_MSGC_MAIN_MIGRATE_END to migration target
(4) wait for SPICE_MSG_MAIN_INIT
(4) switch all channels to migration target
Signed-off-by: Yonit Halperin
---
client
Implement on_disconnect_mig_src and on_connect_mig_target in order to avoid
unnecessary cleanups done in on_(disconnet|connect).
In addition, do not request guest display settings changes after migration.
Signed-off-by: Yonit Halperin
---
client/red_client.cpp |9 +
client
Signed-off-by: Yonit Halperin
---
client/audio_channels.h | 12 ++--
client/playback_channel.cpp | 22 --
client/record_channel.cpp | 39 ---
3 files changed, 54 insertions(+), 19 deletions(-)
diff --git a/client
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 157
client/display_channel.h | 10 +++-
2 files changed, 153 insertions(+), 14 deletions(-)
diff --git a/client/display_channel.cpp b/client/display_channel.cpp
index 6127a96
Fix not destroying surfaces and other data (e.g., streams) upon disconnection.
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 18 --
client/display_channel.h |1 +
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/client/display_channel.cpp
It can't actually happen right now, since switch-host migration scheme will take
place if the src/target server has protocol 1.
Signed-off-by: Yonit Halperin
---
client/red_channel.cpp | 20
client/red_channel.h |2 ++
client/red_client.cpp |
Signed-off-by: Yonit Halperin
---
NEWS |8
configure.ac |2 +-
server/spice-server.syms |4
server/spice.h |2 +-
4 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index ee6ceec..e9ed92e 100644
Hi,
last fix before pushing to 0.8 branch the semi-seamless migration series.
I wanted to avoid sending v5 for all the series.
Yonit.
Yonit Halperin (1):
server: fix not calling migrate_connect completion callback
server/reds.c | 18 --
1 files changed, 8 insertions(+), 10
should call
the
migrate_connect completion callback. Since reds->mig_inprogress
wasn't set appropriately, it wasn't called.
Signed-off-by: Yonit Halperin
---
server/reds.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/server/reds.c b/server
On 09/28/2011 01:15 AM, Uri Lublin wrote:
On 09/25/2011 03:36 PM, Yonit Halperin wrote:
(1) send SPICE_MSG_MAIN_MIGRATE_BEGIN upon spice_server_migrate_connect
(2) wait for SPICE_MSGC_MAIN_MIGRATE_(CONNECTED|CONNECT_ERROR), or a
timeout, in order
to complete client_migrate_info monitor command
On 10/02/2011 03:24 PM, Alon Levy wrote:
Hi,
I'm trying to acheive the $subject. Some background: currently spice relies
on a preallocated pci bar for both surfaces and for VGA framebuffer + commands.
I have been trying to get rid of the surfaces bar. To do that I allocate memory
in the gue
On 10/04/2011 01:20 PM, Alon Levy wrote:
On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote:
On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote:
Unless I'm misreading the code (which may very well be), the
function looks like:
if (mask_bitmap&& m) {
if (this or that) {
On 10/11/2011 12:55 PM, Gerd Hoffmann wrote:
+/* spice (semi-)seamless client migration */
+int spice_server_migrate_connect(SpiceServer *s, const char* dest,
+ int port, int secure_port,
+ const char* cert_subject);
This must be added to server/spice-server.syms
cheers,
Gerd
Welcome back :)
rrive after spice_server_migrate_connect and
before spice_server_migrate_end,
will receive SWITCH_HOST when migration completes.
If it will be necessary, I will change the 0.8 branch as well.
Yonit
Yonit Halperin (19):
server: set & test channel capabilities in red_channel
server/spic
The code for setting and testing channel capabilities was
unnecessarily duplicated. Now it is in red_channel.
Signed-off-by: Yonit Halperin
---
server/inputs_channel.c|4 +-
server/main_channel.c | 27
server/main_channel.h | 20 --
server/red_channel.c
_migrate_info
command.
(cherry picked from commit 6e56bea67c5648b0c81990171d4bc0cf1a402043 branch 0.8)
Conflicts:
server/spice.h
Signed-off-by: Yonit Halperin
---
server/reds.c |9 +
server/spice-experimental.h |3 ---
server/spice.h
Conflicts:
server/reds.h
Signed-off-by: Yonit Halperin
---
server/reds.c | 29 +
server/reds.h |4
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 79c2796..40b54bb 100644
--- a/server/reds.c
Conflicts:
configure.ac
Signed-off-by: Yonit Halperin
---
configure.ac |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2afc559..203e82f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -132,7 +132,7 @@ AM_CONDITIONAL
from commit 5560c56ef05c74da5e0e0825dc1f134019593cad branch 0.8;
Was modified to support the separation of main channel from reds, and multiple
clients)
Conflicts:
server/reds.c
Signed-off-by: Yonit Halperin
---
common/messages.h |2 +
server/main_channel.c | 164
Signed-off-by: Yonit Halperin
---
spice.proto |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/spice.proto b/spice.proto
index 78c1fad..266e03a 100644
--- a/spice.proto
+++ b/spice.proto
@@ -219,6 +219,8 @@ channel MainChannel : BaseChannel {
uint8
commit 4b82580fc36228af13db4ac3c403753d6b5c40b5 branch 0.8;
Was modified to support multiple clients, and the separation of main_channel
from reds)
Conflicts:
server/reds.c
Signed-off-by: Yonit Halperin
---
server/main_channel.c | 111
Signed-off-by: Yonit Halperin
---
server/reds.c | 45 -
1 files changed, 28 insertions(+), 17 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 20032a9..2deed4c 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1596,13 +1596,36
channles are linked before and ater migration. i.e.,
SPICE_MSGC_MAIN_ATTACH_CHANNELS is not sent from the clients.
Signed-off-by: Yonit Halperin
---
server/main_channel.c | 53 +++-
server/main_channel.h |2 +-
server/red_channel.c | 15 +++-
server/red_channel.h |6
We will add a qemu call to spice_server_migrate_start when migration starts.
For now, it does nothing, but we may need this notification in the future.
(cherry picked from commit b8213167717979e6f2fb52646e43eb458634e6a1 branch 0.8)
Signed-off-by: Yonit Halperin
---
server/reds.c |8
-off-by: Yonit Halperin
---
client/canvas.cpp | 25 +++-
client/canvas.h| 152
client/display_channel.cpp | 149 +++
client/display_channel.h | 18 +-
client/red_gdi_canvas.cpp
RHBZ 725009, 738270
(cherry picked from commit 31ed2519a752b7332ed40d0d7ab02e938c0e65cb branch 0.8)
Conflicts:
client/red_client.cpp
Signed-off-by: Yonit Halperin
---
client/red_client.cpp | 23 ---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a
510a4ff7c4f188fe6d0fb12198b8f9fdb74b9a2d branch 0.8)
Conflicts:
client/red_channel.h
Signed-off-by: Yonit Halperin
---
client/red_channel.cpp | 60 +++
client/red_channel.h | 19
client/red_client.cpp | 107 +++-
client
-by: Yonit Halperin
---
client/red_client.cpp |9 +
client/red_client.h |2 ++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 84440c1..4fc442f 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
Signed-off-by: Yonit Halperin
---
client/audio_channels.h | 12 ++--
client/playback_channel.cpp | 22 --
client/record_channel.cpp | 39 ---
3 files changed, 54 insertions(+), 19 deletions(-)
diff --git a/client
Conflicts:
client/display_channel.cpp
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 157
client/display_channel.h | 10 +++-
2 files changed, 153 insertions(+), 14 deletions(-)
diff --git a/client/display_channel.cpp b
Fix not destroying surfaces and other data (e.g., streams) upon disconnection.
(cherry picked from commit 010b22cd771b7e81363b4b6521e4265b093fcd25 branch 0.8)
Signed-off-by: Yonit Halperin
---
client/display_channel.cpp | 18 --
client/display_channel.h |1 +
2 files
It can't actually happen right now, since switch-host migration scheme will take
place if the src/target server has protocol 1.
(cherry picked from commit 4b2bf4d88c253502003aa5e4b93a045742eec9b4 branch 0.8)
Signed-off-by: Yonit Halperin
---
client/red_channel.cpp |
Signed-off-by: Yonit Halperin
---
NEWS |8
configure.ac |2 +-
server/spice-server.syms |1 +
3 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 8b56038..a862449 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,11
be called upon migration start/end
** spice_server_start and the migrate_end_complete callback, were added for
future use, in case we implement a real seamless spice migration
Yonit Halperin (2):
spice: turn client_migrate_info to async
spice: support the new migration interface (spice 0.
cb will be called after spice client has been
connected to the target (or a timeout). See following patches and spice patches.
Signed-off-by: Yonit Halperin
---
hmp-commands.hx |3 ++-
monitor.c |6 --
qmp-commands.hx |3 ++-
ui/qemu-spice.h | 14 +++---
ui/spice
- call spice_server_migrate_(start|end|connect).
- register spice_migrate_connect completion callback
Signed-off-by: Yonit Halperin
---
ui/spice-core.c | 56 ++-
1 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c
On 09/08/2011 02:17 AM, Alon Levy wrote:
Hi,
I think this patch is sufficient for the 0.8 branch (+ the comments
bellow + locks (for several display channels threads)).
However for master, due to the red_channel refactoring I think we should
have a more general dispatcher. It would be nice if (1
Call ASSERT(red_channel_client_no_item_being_sent) only if
red_wait_outgoing_item/s did not timeout.
Signed-off-by: Yonit Halperin
---
server/red_worker.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 7af715d
will prevent
access to pci memory that was released.
RHBZ: 744518
Signed-off-by: Yonit Halperin
---
hw/qxl.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 03848ed..c9b60a2 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -238,6 +238,9 @@
Hi,
Sounds like https://bugzilla.redhat.com/show_bug.cgi?id=746950 and
https://bugs.freedesktop.org/show_bug.cgi?id=41858
Alon's patch:
http://lists.freedesktop.org/archives/spice-devel/2011-September
/005369.html
Should solve it.
Cheers,
Yonit.
On 10/21/2011 05:26 PM, Daniel P. Berrange wrote
On 10/23/2011 07:10 PM, Alon Levy wrote:
add main_dispatcher, a message passing mechanism for sending messages to
the main thread. The main thread is the thread that implements
SpiceCoreInterface, which is assumed to be a single thread.
Similar to the async operation of red_worker, a socket pair
ACK
On 10/24/2011 02:25 PM, Alon Levy wrote:
add main_dispatcher, a message passing mechanism for sending messages to
the main thread. The main thread is the thread that implements
SpiceCoreInterface, which is assumed to be a single thread.
Similar to the async operation of red_worker, a socket
On 11/01/2011 11:34 PM, Alon Levy wrote:
On Wed, Oct 12, 2011 at 12:38:59PM +0200, Yonit Halperin wrote:
(1) not sending anything to a migrated client till we recieve
SPICE_MSGC_MIGRATE_END
(2) start a new client migration (handle client_migrate_info) only after
SPICE_MSGC_MIGRATE_END
Hi,
One comment bellow. Besides that, Ack.
On 11/01/2011 10:10 AM, Alon Levy wrote:
This is part of the dispatcher update, extracting the dispatcher routine
from red_dispatcher and main_dispatcher into dispatcher.
Supporting multiple async operations will make it natural to support
async monit
On 11/01/2011 10:10 AM, Alon Levy wrote:
used for main_dispatcher only in this patch.
Dispatcher is meant to be used for Main<->any low frequency messages.
It's interface is meant to include the red_dispatcher usage:
fixed size messages per message type
some messages require an ack
Some me
On 11/01/2011 10:10 AM, Alon Levy wrote:
used for main_dispatcher only in this patch.
Dispatcher is meant to be used for Main<->any low frequency messages.
just curious: what is the advantage of using a pipe over an explicit
ring of messages with signalling for writes and acks?
__
On 11/01/2011 10:10 AM, Alon Levy wrote:
This patch reuses Dispatcher in RedDispatcher. It adds two helpers
to red_worker to keep RedWorker opaque to the outside. The dispatcher is
abused in three places that use the underlying socket directly:
once sending a READY after red_init completes
on
On 11/02/2011 10:06 PM, Hans de Goede wrote:
Hi,
Hi all,
Today I've tried to build (succeeded) and run (failed)
spice + qemu from upstream git (1.0-rc0) I tried both
regular qemu as well as qemu-kvm.
In both cases the qemu binary works fine as long as I don't
start it with -vga qxl.
What exact
Hi,
just trailing whitespace.
Ack.
On 11/06/2011 06:49 PM, Alon Levy wrote:
---
common/spice_common.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/spice_common.h b/common/spice_common.h
index 51c6a68..f6205a3 100644
--- a/common/spice_common.h
+++ b/common/s
101 - 200 of 941 matches
Mail list logo
