Re: [Spice-devel] [spice-gtk 08/13] usb-redir: change signal prototype of win-usb-dev

2019-03-13 Thread Yuri Benditovich
On Tue, Mar 12, 2019 at 4:02 PM Christophe Fergeau wrote: > > On Sun, Mar 10, 2019 at 04:46:07PM +0200, Yuri Benditovich wrote: > > Changing signal definition from (boxed-boxed) to (pointer,int). > > There is no need for additional referencing of GUdevDevice > > object before signal callback. > >

Re: [Spice-devel] [spice-gtk 08/13] usb-redir: change signal prototype of win-usb-dev

2019-03-12 Thread Christophe Fergeau
On Sun, Mar 10, 2019 at 04:46:07PM +0200, Yuri Benditovich wrote: > Changing signal definition from (boxed-boxed) to (pointer,int). > There is no need for additional referencing of GUdevDevice > object before signal callback. I still feel it would be nicer to guarantee the GUdevDevice will stay

[Spice-devel] [spice-gtk 08/13] usb-redir: change signal prototype of win-usb-dev

2019-03-10 Thread Yuri Benditovich
Changing signal definition from (boxed-boxed) to (pointer,int). There is no need for additional referencing of GUdevDevice object before signal callback. Second parameter (action) is 0 for device removal and 1 for device addition. Signed-off-by: Yuri Benditovich --- src/usb-device-manager.c |