Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-24 Thread Alon Levy
On 10/08/2014 01:10 PM, Marc-André Lureau wrote: ping I didn't test this, looks good, just one single line if, do with it as you will. And unrelated, but you use TRUE/FALSE constants for handled, maybe nice to use them too (at least be consistent that is) in vdagent_x11_handle_event. On Mon,

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
ping On Mon, Sep 8, 2014 at 11:34 AM, Marc-André Lureau marcandre.lur...@gmail.com wrote: ping On Wed, Aug 27, 2014 at 8:51 PM, Marc-André Lureau marcandre.lur...@redhat.com wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com Make sure vdagent follows the current monitor

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
On Wed, Aug 27, 2014 at 08:51:10PM +0200, Marc-André Lureau wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com Make sure vdagent follows the current monitor configuration. This solves a number of issue where the pointer input is off, because the uinput tablet isn't reconfigured.

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 2:07 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Aug 27, 2014 at 08:51:10PM +0200, Marc-André Lureau wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com Make sure vdagent follows the current monitor configuration. This solves a number of issue

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 02:25:08PM +0200, Marc-André Lureau wrote: On Wed, Oct 8, 2014 at 2:07 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Aug 27, 2014 at 08:51:10PM +0200, Marc-André Lureau wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com Make sure vdagent

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 3:23 PM, Christophe Fergeau cferg...@redhat.com wrote: RRCrtcChangeNotify is a event subtype of RRNotify, since that's the only one we can catch here, no need to filter futher. well, let's use the more specific type then, this is the one which was used before so it

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 03:49:29PM +0200, Marc-André Lureau wrote: On Wed, Oct 8, 2014 at 3:23 PM, Christophe Fergeau cferg...@redhat.com wrote: RRCrtcChangeNotify is a event subtype of RRNotify, since that's the only one we can catch here, no need to filter futher. well, let's use

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Christophe Fergeau
And I forgot again to mention that you need a #include glib.h or this won't compile because of TRUE/FALSE. Christophe On Wed, Oct 08, 2014 at 03:59:57PM +0200, Christophe Fergeau wrote: On Wed, Oct 08, 2014 at 03:49:29PM +0200, Marc-André Lureau wrote: On Wed, Oct 8, 2014 at 3:23 PM,

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-08 Thread Marc-André Lureau
On Wed, Oct 8, 2014 at 4:07 PM, Christophe Fergeau cferg...@redhat.com wrote: And I forgot again to mention that you need a #include glib.h or this won't compile because of TRUE/FALSE. right, it was meant to be applied after the remove monitors.xml, but I can reorder it. -- Marc-André

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-09-08 Thread Marc-André Lureau
ping On Wed, Aug 27, 2014 at 8:51 PM, Marc-André Lureau marcandre.lur...@redhat.com wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com Make sure vdagent follows the current monitor configuration. This solves a number of issue where the pointer input is off, because the uinput

[Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-08-27 Thread Marc-André Lureau
From: Marc-Andre Lureau marcandre.lur...@redhat.com Make sure vdagent follows the current monitor configuration. This solves a number of issue where the pointer input is off, because the uinput tablet isn't reconfigured. https://bugzilla.redhat.com/show_bug.cgi?id=1086657 ---