[sqlalchemy] Re: should append_whereclause() return the resulting select?

2007-06-01 Thread Michael Bayer
On Jun 1, 2007, at 3:04 PM, Eric Ongerth wrote: The right usage of append_whereclause() seems to be: s = sometable.select() s.append_whereclause(col==val) etc. I just had a kind of tough time recently when I actually assigned the result instead: s = sometable.select() s =

[sqlalchemy] Re: should append_whereclause() return the resulting select?

2007-06-01 Thread Mike Orr
On 6/1/07, Michael Bayer [EMAIL PROTECTED] wrote: What I'd rather see is either an error warning not to assign the result to anything, or to just have foo.append_whereclause() return the resulting foo. Is that a reasonable request, or are there reasons it shouldn't be done? Unnecessary,

[sqlalchemy] Re: should append_whereclause() return the resulting select?

2007-06-01 Thread Michael Bayer
On Jun 1, 2007, at 5:58 PM, Mike Orr wrote: Returning None is a Python standard, see list.sort(). Making select generative is OK, but it should either modify the select in place or return a new one, not modify it and return it. That's a Perlism. There should be one-- and preferably only

[sqlalchemy] Re: should append_whereclause() return the resulting select?

2007-06-01 Thread Mike Orr
On 6/1/07, Michael Bayer [EMAIL PROTECTED] wrote: the modify in place and return it thing is also how Hibernate criteria queries work. I know nothing about Hibernate. Why is it so great and why are we imitating it? According to Wikipedia it's a Java db framework. So we should make sure

[sqlalchemy] Re: should append_whereclause() return the resulting select?

2007-06-01 Thread Michael Bayer
On Jun 1, 2007, at 7:07 PM, Mike Orr wrote: On 6/1/07, Michael Bayer [EMAIL PROTECTED] wrote: the modify in place and return it thing is also how Hibernate criteria queries work. I know nothing about Hibernate. Why is it so great and why are we imitating it? According to Wikipedia