Re: [sqlalchemy] Selectinload doesn't exploit FK

2019-07-20 Thread yoch melka
I've tested the patch. Works perfectly with my usecase. Thank you very much ! Le vendredi 19 juillet 2019 20:22:40 UTC+3, Mike Bayer a écrit : > > > > On Fri, Jul 19, 2019, at 4:40 AM, yoch melka wrote: > > Thank you for your help. > > I'd be happy to submit a PR (I've already tried to fix this

Re: [sqlalchemy] Selectinload doesn't exploit FK

2019-07-19 Thread Mike Bayer
On Fri, Jul 19, 2019, at 4:40 AM, yoch melka wrote: > Thank you for your help. > > I'd be happy to submit a PR (I've already tried to fix this by myself), but > the code is a little hard to master. I'm glad you tried. The feature is in review at https://gerrit.sqlalchemy.org/#/c/1368/. Of

Re: [sqlalchemy] Selectinload doesn't exploit FK

2019-07-19 Thread yoch melka
Thank you for your help. I'd be happy to submit a PR (I've already tried to fix this by myself), but the code is a little hard to master. Le vendredi 19 juillet 2019 01:24:03 UTC+3, Mike Bayer a écrit : > > > > On Thu, Jul 18, 2019, at 5:02 PM, yoch melka wrote: > > Hi, > > According to the

Re: [sqlalchemy] Selectinload doesn't exploit FK

2019-07-18 Thread Mike Bayer
On Thu, Jul 18, 2019, at 5:02 PM, yoch melka wrote: > Hi, > > According to the documentation > , > from 1.3 "selectin loading can omit the JOIN for a simple one-to-many > collection" in case if the PK is

[sqlalchemy] Selectinload doesn't exploit FK

2019-07-18 Thread yoch melka
Hi, According to the documentation , from 1.3 "selectin loading can omit the JOIN for a simple one-to-many collection" in case if the PK is known by the primary request. But in the opposite case that we know