Re: [sqlalchemy] group by and order by aliasing on custom dialects

2018-01-05 Thread Mike Bayer
On Fri, Jan 5, 2018 at 10:03 AM, Florian Apolloner wrote: > Hi Mike, > > you are to fast for me! Those work, thanks. > > Aside from the oracle requirements I also get: > ``` > 'Requirements' object has no attribute 'order_by_col_from_union' > ``` > -- should that be added to the base requirements

Re: [sqlalchemy] group by and order by aliasing on custom dialects

2018-01-05 Thread Florian Apolloner
Hi Mike, you are to fast for me! Those work, thanks. Aside from the oracle requirements I also get: ``` 'Requirements' object has no attribute 'order_by_col_from_union' ``` -- should that be added to the base requirements with exclusions.open? Cheers, Florian On Thursday, January 4, 2018 at 10

Re: [sqlalchemy] group by and order by aliasing on custom dialects

2018-01-04 Thread Mike Bayer
Please see the merges: https://gerrit.sqlalchemy.org/622 https://gerrit.sqlalchemy.org/621 which should resolve both of these. On Thu, Jan 4, 2018 at 10:37 AM, Mike Bayer wrote: > On Thu, Jan 4, 2018 at 5:46 AM, Florian Apolloner > wrote: >> Hi there, >> >> I am writing a custom dialect and

Re: [sqlalchemy] group by and order by aliasing on custom dialects

2018-01-04 Thread Mike Bayer
On Thu, Jan 4, 2018 at 5:46 AM, Florian Apolloner wrote: > Hi there, > > I am writing a custom dialect and sqlalchemy currently generates a statement > like this: > > ``` > SELECT count(some_table.id) AS count_1, some_table.x + some_table.y AS lx > FROM some_table GROUP BY some_table.x + some_tabl

[sqlalchemy] group by and order by aliasing on custom dialects

2018-01-04 Thread Florian Apolloner
Hi there, I am writing a custom dialect and sqlalchemy currently generates a statement like this: ``` SELECT count(some_table.id) AS count_1, some_table.x + some_table.y AS lx FROM some_table GROUP BY some_table.x + some_table.y ORDER BY lx ``` As you can see it uses the alias lx in ORDER BY b