Re: [sqlalchemy] possible bug on sqlite regarding automatic constraints when using alembic recommended naming conventions

2019-07-26 Thread Jonathan Vanasco
That's great, Mike. I will help out on this and handle the below. I'll do a Github ticket for tracking, and you can assign it to me. On Thursday, July 25, 2019 at 9:44:10 PM UTC-4, Mike Bayer wrote: > > > > On Mon, Jul 22, 2019, at 10:51 PM, Jonathan Vanasco wrote: > > > > On Monday, July

Re: [sqlalchemy] possible bug on sqlite regarding automatic constraints when using alembic recommended naming conventions

2019-07-25 Thread Mike Bayer
On Mon, Jul 22, 2019, at 10:51 PM, Jonathan Vanasco wrote: > > > On Monday, July 22, 2019 at 9:36:10 PM UTC-4, Mike Bayer wrote: >> >> likely , the "create_constraint" flag should default to False for booleans >> and enums. I think it was a mistake to default these to true, I think people

Re: [sqlalchemy] possible bug on sqlite regarding automatic constraints when using alembic recommended naming conventions

2019-07-22 Thread Jonathan Vanasco
On Monday, July 22, 2019 at 9:36:10 PM UTC-4, Mike Bayer wrote: > > likely , the "create_constraint" flag should default to False for booleans > and enums. I think it was a mistake to default these to true, I think > people usually don't care. > Everything you said was apparent to me, but

Re: [sqlalchemy] possible bug on sqlite regarding automatic constraints when using alembic recommended naming conventions

2019-07-22 Thread Mike Bayer
On Mon, Jul 22, 2019, at 6:01 PM, Jonathan Vanasco wrote: > Mike- > > I'm not sure if this is a bug or docs incompatibility issue, and I know > metadata may be going away soon... but I'm leaning towards a bug. > > I was setting up a test suite for a Pyramid plugin, and used the Alembic >

[sqlalchemy] possible bug on sqlite regarding automatic constraints when using alembic recommended naming conventions

2019-07-22 Thread Jonathan Vanasco
Mike- I'm not sure if this is a bug or docs incompatibility issue, and I know metadata may be going away soon... but I'm leaning towards a bug. I was setting up a test suite for a Pyramid plugin, and used the Alembic naming conventions (https://alembic.sqlalchemy.org/en/latest/naming.html)