[sqlalchemy] ticket #877

2010-02-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I would like to write a patch for ticket #877. What is the best method to implement the requested feature? The ExecutionContext class has a post_exec method, so the implementation for the psycopg2 driver can override this method, check for the

Re: [sqlalchemy] ticket #877

2010-02-28 Thread Michael Trier
On Feb 28, 2010, at 11:21 AM, Manlio Perillo wrote: By the way, it seems there is a bug in the documentation: http://www.sqlalchemy.org/docs/reference/sqlalchemy/connections.html?highlight=create_engine#sqlalchemy.create_engine echo=False – if True, the Engine will log all statements as well

Re: [sqlalchemy] ticket #877

2010-02-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Bayer ha scritto: On Feb 28, 2010, at 11:21 AM, Manlio Perillo wrote: I would like to write a patch for ticket #877. What is the best method to implement the requested feature? The ExecutionContext class has a post_exec method, so

Re: [sqlalchemy] ticket #877

2010-02-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Bayer ha scritto: On Feb 28, 2010, at 11:21 AM, Manlio Perillo wrote: I would like to write a patch for ticket #877. Sorry, I forgot to update the log level used in the patch (I was doing some tests with the engine `echo` parameter).

Re: [sqlalchemy] ticket #877

2010-02-28 Thread Michael Bayer
On Feb 28, 2010, at 12:33 PM, Manlio Perillo wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Bayer ha scritto: On Feb 28, 2010, at 11:21 AM, Manlio Perillo wrote: I would like to write a patch for ticket #877. What is the best method to implement the requested feature?

Re: [sqlalchemy] ticket #877

2010-02-28 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Bayer ha scritto: Done, new patch attached. The is also a bug fix: I forgot to clear the notices list. The notices list is cleared *only* if messages are actually logged. I took the liberty to change the coding style, too. If patch