[sqlite] Bug: SQLite 3.27.1 does not compile with SQLITE_OMIT_WINDOWFUNC

2019-02-10 Thread Victor Costan
In case it helps anyone else, I plan to use the patch below to bypass the compilation error in Chrome. I'd appreciate a sanity check. I would also be very grateful for a check-in that addresses the compilation issue, so we can remove our patch in a future update. Thank you very much! Victor

Re: [sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Victor Costan
Thank you very much, Dan! I was about to come back to report that my fix is incorrect. Your fix does the trick. Thank you! Victor On Fri, Nov 16, 2018 at 6:38 AM Dan Kennedy wrote: > On 11/16/2018 08:41 PM, Victor Costan wrote: > > The amalgamation build ships two de

[sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Victor Costan
The amalgamation build ships two definitions of sqlite3_complete(). Most builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined, shell.c supplies a stub definition -- thank you very much for adding that! Unfortunately, the stub definition in shell.c does not have the SQLITE_API

[sqlite] Bug: ALTER TABLE RENAME (still) calls authorizer functions

2018-10-05 Thread Victor Costan
The description for https://www3.sqlite.org/src/info/eac2aa7dce577f19 includes "Do not invoke the authorizer callback when parsing schema items as part of ALTER TABLE commands." In SQLite 3.25.2, the authorizer is called for the internal functions sqlite_rename_columns, sqlite_rename_table and

Re: [sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-08-14 Thread Victor Costan
On Mon, Jul 23, 2018 at 3:57 AM Dan Kennedy wrote: > On 07/22/2018 07:48 PM, Victor Costan wrote: > > In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation > > errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. > > > > This is because src/cti

[sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-07-22 Thread Victor Costan
In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. This is because src/ctime.c includes the following block: #ifdef SQLITE_DEFAULT_LOOKASIDE "DEFAULT_LOOKASIDE=" CTIMEOPT_VAL(SQLITE_DEFAULT_LOOKASIDE), #endif