Re: [sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-08-14 Thread Victor Costan
On Mon, Jul 23, 2018 at 3:57 AM Dan Kennedy wrote: > On 07/22/2018 07:48 PM, Victor Costan wrote: > > In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation > > errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. > > > > This is because src/ctime.c includes the following

Re: [sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-07-23 Thread Dominique Devienne
On Mon, Jul 23, 2018 at 5:37 PM Dan Kennedy wrote: > On 07/23/2018 06:36 PM, Dominique Devienne wrote: > > On Mon, Jul 23, 2018 at 12:57 PM Dan Kennedy > wrote: > > The diff adds: > > > > #define CTIMEOPT_VAL2_(opt1,opt2) #opt1 "," #opt2 > > #define CTIMEOPT_VAL2(opt) CTIMEOPT_VAL2_(opt) > > >

Re: [sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-07-23 Thread Dan Kennedy
On 07/23/2018 06:36 PM, Dominique Devienne wrote: On Mon, Jul 23, 2018 at 12:57 PM Dan Kennedy wrote: On 07/22/2018 07:48 PM, Victor Costan wrote: In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. This is

Re: [sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-07-23 Thread Dominique Devienne
On Mon, Jul 23, 2018 at 12:57 PM Dan Kennedy wrote: > On 07/22/2018 07:48 PM, Victor Costan wrote: > > In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation > > errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. > > > > This is because src/ctime.c includes the

Re: [sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-07-23 Thread Dan Kennedy
On 07/22/2018 07:48 PM, Victor Costan wrote: In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. This is because src/ctime.c includes the following block: #ifdef SQLITE_DEFAULT_LOOKASIDE "DEFAULT_LOOKASIDE="

[sqlite] Bug: SQLITE_DEFAULT_LOOKASIDE does not compile without SQLITE_OMIT_COMPILEOPTION_DIAGS

2018-07-22 Thread Victor Costan
In a custom SQLite build, SQLITE_DEFAULT_LOOKASIDE results in compilation errors, unless used with SQLITE_OMIT_COMPILEOPTION_DIAGS. This is because src/ctime.c includes the following block: #ifdef SQLITE_DEFAULT_LOOKASIDE "DEFAULT_LOOKASIDE=" CTIMEOPT_VAL(SQLITE_DEFAULT_LOOKASIDE), #endif