Re: [sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE

2017-02-21 Thread Joe Mistachkin
Detlef Golze wrote: > > This code still assumes that SQLITE_WIN32_CACHE_SIZE is measured in pages: > The value of SQLITE_WIN32_HEAP_INIT_SIZE is an initial estimate of the eventual heap size. It does not have to be an exact figure. Using either KiB or pages normally ends up giving a fairly

Re: [sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE

2017-02-20 Thread Detlef Golze
IZE if SQLITE_DEFAULT_PAGE_SIZE is specified as negative value (Kbyte). Thanks, Detlef. -Original Message- From: sqlite-users [mailto:sqlite-users-boun...@mailinglists.sqlite.org] On Behalf Of Joe Mistachkin Sent: Monday, February 20, 2017 8:25 PM To: 'SQLite mailing list' Subject: Re: [sqlite] Bug? Incorrect

Re: [sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE

2017-02-20 Thread Joe Mistachkin
Detlef Golze wrote: > > Changes carried forward from version 3.12.0 (2016-03-29): > Ah, right. I was reading the comments in the source code. I've checked-in some changes that should prevent integer overflows when very large values are used for the SQLITE_DEFAULT_CACHE_SIZE and/or

Re: [sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE

2017-02-20 Thread Detlef Golze
Joe Mistachkin Sent: Monday, February 20, 2017 10:02 AM To: 'SQLite mailing list' Subject: Re: [sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE Detlef Golze wrote: > > SQLITE_DEFAULT_CACHE_SIZE is defined as page size if positive or > Kbyte if negative. > The SQLITE_DEFAULT_C

Re: [sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE

2017-02-20 Thread Joe Mistachkin
Detlef Golze wrote: > > SQLITE_DEFAULT_CACHE_SIZE is defined as page size if positive or > Kbyte if negative. > The SQLITE_DEFAULT_CACHE_SIZE value is always measured in pages. > > I came here because I got an integer overflow in the definition > of SQLITE_WIN32_HEAP_INIT_SIZE. > What values

[sqlite] Bug? Incorrect use of SQLITE_DEFAULT_CACHE_SIZE

2017-02-20 Thread Detlef Golze
Hi, the following looks like an incorrect use of SQLITE_DEFAULT_CACHE_SIZE (amalgamation 3.17 starting at line 37963): /* * This is cache size used in the calculation of the initial size of the * Win32-specific heap. It cannot be negative. */ #ifndef SQLITE_WIN32_CACHE_SIZE # if