Re: [sqlite] Unreachable code in pager.c

2005-06-23 Thread Jay Sprenkle
I counted the parens, and you're right. It's definitely not reachable. > I think the compiler is right. I am not familiar with the sqlite3 source > code, but the break at line 1330 breaks the for() loop at line 1324, NOT > the while() loop at line 1281. Is that as it is intended, or is it a > po

Re: [sqlite] Unreachable code in pager.c

2005-06-23 Thread D. Richard Hipp
On Thu, 2005-06-23 at 15:52 +0200, F.W.A. van Leeuwen wrote: > I think the compiler is right. I am not familiar with the sqlite3 source > code, but the break at line 1330 breaks the for() loop at line 1324, NOT > the while() loop at line 1281. Is that as it is intended, or is it a > potential b

Re: [sqlite] Unreachable code in pager.c

2005-06-23 Thread F.W.A. van Leeuwen
The (inner) for() loop will terminate when i>=nRec. But it is inside an (outer) while(1) loop. So the code below the while(1) is still unreachable. Frank

Re: [sqlite] Unreachable code in pager.c

2005-06-23 Thread Jay Sprenkle
On 6/23/05, F.W.A. van Leeuwen <[EMAIL PROTECTED]> wrote: > While cross-compiling sqlite3.2.1, my Blackfin C compiler gives the > following warning: > > ".\src\pager.c", line 1342: cc0111: {D} warning: statement is unreachable > assert( rc==SQLITE_OK ); > > The context is: > > > /* This l

[sqlite] Unreachable code in pager.c

2005-06-23 Thread F.W.A. van Leeuwen
While cross-compiling sqlite3.2.1, my Blackfin C compiler gives the following warning: ".\src\pager.c", line 1342: cc0111: {D} warning: statement is unreachable assert( rc==SQLITE_OK ); The context is: /* This loop terminates either when the readJournalHdr() call returns ** SQLITE_DONE