On Tuesday 27 November 2007, Oleg Broytmann wrote:
> On Tue, Nov 27, 2007 at 10:02:24PM +0200, Dan Pascu wrote:
> > Ok, makes sense not to set it everytime a new connection object is
> > created. But then how about the other things that get set below in
> > the if using_sqlite2 block that starts at
On Tue, Nov 27, 2007 at 10:02:24PM +0200, Dan Pascu wrote:
> Ok, makes sense not to set it everytime a new connection object is
> created. But then how about the other things that get set below in the
> if using_sqlite2 block that starts at line 51 in sqliteconnection.py (in
> the trunk version)
On Tuesday 27 November 2007, Oleg Broytmann wrote:
> On Tue, Nov 27, 2007 at 09:34:31PM +0200, Dan Pascu wrote:
> > I think the extra if using_sqlite2 test you added is not necessary.
> > There is already such a test a bit below that could accommodate the 2
> > lines:
> >
> > sqlite.encode = base64
On Tue, Nov 27, 2007 at 09:34:31PM +0200, Dan Pascu wrote:
> I think the extra if using_sqlite2 test you added is not necessary. There
> is already such a test a bit below that could accommodate the 2 lines:
>
> sqlite.encode = base64.encodestring
> sqlite.decode = base64.decodestring
>
> In fac
On Tuesday 27 November 2007, Oleg Broytmann wrote:
> On Fri, Nov 09, 2007 at 09:13:30AM +0200, Dan Pascu wrote:
> > IMO if we use pysqlite2 or sqlite3 we shouldn't import
> > encoders/decoders from the old sqlite module, but instead use base64
> > always.
>
>Fixed in the revisions 3158-3161 (0.
On Fri, Nov 09, 2007 at 09:13:30AM +0200, Dan Pascu wrote:
> There is an issue in the sqlite backend regarding encoding/decoding. Below
> is the relevant code from the __init__ method:
>
> class SQLiteConnection(DBAPI):
> [...]
> def __init__(self, filename, autoCommit=1, **kw):
>
On Fri, Nov 09, 2007 at 09:13:30AM +0200, Dan Pascu wrote:
> try:
> from sqlite import encode, decode
> except ImportError:
> import base64
> sqlite.encode = base64.encodestring
> sqlite.decode = base64.decodest
There is an issue in the sqlite backend regarding encoding/decoding. Below
is the relevant code from the __init__ method:
class SQLiteConnection(DBAPI):
[...]
def __init__(self, filename, autoCommit=1, **kw):
global sqlite
global using_sqlite2
if sqlite is None:
