Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-05 Thread reinholdk
Looks really good so far, thanks a lot! reinholdk's Profile: http://forums.slimdevices.com/member.php?userid=36070 View this thread: http://forums.slimdevices.com/showthread.php?t=106700 ___

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-04 Thread Michael Herger
Great, thanks a lot, Michael. Probably it'll take a few days for me to try it, but I'll report back. No need to apply the patch I posted. Just update LMS to the latest. -- Michael ___ Squeezecenter mailing list Squeezecenter@lists.slimdevices.com htt

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-04 Thread reinholdk
Great, thanks a lot, Michael. Probably it'll take a few days for me to try it, but I'll report back. reinholdk's Profile: http://forums.slimdevices.com/member.php?userid=36070 View this thread: http://forums.slimdevices.com

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-03 Thread mherger
Here's what I've found so far... does cover web UI and controllers, but not ip3k players. Code: diff --git a/HTML/Classic/status_header.html b/HTML/Classic/status_header.html index a0416b5..d9c9803 100644 --- a/HTML/Classic/status_header.html +++ b/HTML/Classic/st

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-03 Thread reinholdk
Sounds like it's too much effort to fix it at all places. Although I think I'll keep the workaround with the modified album title in place then, I'd still apply the patch for creating the album. Better to have the album visible without title than hidden & merged with other tracks in the 'No Album

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-03 Thread Michael Herger
Done. Thanks. There are a few places where the web UI doesn't show the title, e.g. in the navigation bar on top of the left pane or in the album list of that artist. There's more: controllers (Touch UI, iPeng etc.) wouldn't show the album name either... -- -- Michael

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-03 Thread reinholdk
mherger wrote: > Could you please drop a sample track to my inbox? > Done. There are a few places where the web UI doesn't show the title, e.g. in the navigation bar on top of the left pane or in the album list of that artist. -

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-03 Thread mherger
Could you please drop a sample track to my inbox? https://www.dropbox.com/request/T3RctyzGgNg0oFDubq6a Thanks! Michael http://www.herger.net/slim-plugins - MusicArtistInfo, MusicInfoSCR mherger's Profile: http://forums.

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-03 Thread reinholdk
mherger wrote: > Would you be able to edit a file and give the following patch a try? > Well, it nearly worked. I used my older LMS in a Linux VM and after stopping LMS, modifying /usr/lib/perl5/vendor_perl/Slim/Schema.pm, restarting LMS and performing a full scan, the album was created correct

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2017-01-02 Thread mherger
Would you be able to edit a file and give the following patch a try? Code: diff --git a/Slim/Schema.pm b/Slim/Schema.pm index ce80fbd..622d2b0 100644 --- a/Slim/Schema.pm +++ b/Slim/Schema.pm @@ -907,7 +907,7 @@ } # If the album does not

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-30 Thread reinholdk
d6jg wrote: > There is also Damien Rice's 0 (or is it O as it appears I have it as) - > https://en.wikipedia.org/wiki/O_(Damien_Rice_album) Have it as well - as O. reinholdk's Profile: http://forums.slimdevices.com/member

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-30 Thread d6jg
reinholdk wrote: > I agree that an album named 0 is pretty unusual, but I just got one > (https://en.wikipedia.org/wiki/0_(Low_Roar_album)). And apart from > technical issues it's not different from a name like 1, which is quite > famous. > > There is also Damien Rice's 0 (or is it O as it ap

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-29 Thread reinholdk
mherger wrote: > Ok, I can see where this is coming from: in Perl 0 is the same as false > > or an empty string, if treated in a boolean context. Most likely there's > > some lazy check like "if there's no name, then set it to no album". I > can look into this. Setting the name to "0" (incl. t

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-29 Thread Michael Herger
-WHERE albumname is null- instead of -WHERE Albumname <> ''- Except that I don't see 0 in your logic. 0 is not the same as null. But I guess in a simplified world this doesn't really matter :-). -- Michael ___ Squeezecenter mailing list Squeezecent

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-29 Thread Michael Herger
If an album is titled "0" (that is, all of the flac files for its tracks have the Album tag set to the character zero, without quotes) then the scanner treats it as if no album tag is present and LMS shows the tracks under the virtual album "No Album". Ok, I can see where this is coming from: in

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-28 Thread DJanGo
edit: mea culpa seems to be i am complete wrong... a qucik look takes me to that line: Code: /usr/share/perl5/Slim/Control/Queries.pm: push @{$w}, '(albums.compilation IS NULL OR albums.compilation = 0)'; That means

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-28 Thread DJanGo
reinholdk wrote: > I agree that an album named 0 is pretty unusual, but I just got one > (https://en.wikipedia.org/wiki/0_(Low_Roar_album)). Found that too after i your post ;) reinholdk wrote: > Not sure if I get your point about the queries. The Album tag in the > files is present and is nei

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-28 Thread reinholdk
I agree that an album named 0 is pretty unusual, but I just got one (https://en.wikipedia.org/wiki/0_(Low_Roar_album)). And apart from technical issues it's not different from a name like 1, which is quite famous. Not sure if I get your point about the queries. The Album tag in the files is prese

Re: [SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-28 Thread DJanGo
reinholdk wrote: > Anybody else ever experienced this? seems pretty "normal" to me and looks like: -WHERE albumname is null- instead of -WHERE Albumname <> ''- but to be honest a Albumname like 0 is pretty unusual. I dont think a quick fix without some unwanted sidefeatures is easy... -

[SlimDevices: SqueezeCenter] Scanner ignores album title "0"

2016-12-28 Thread reinholdk
If an album is titled "0" (that is, all of the flac files for its tracks have the Album tag set to the character zero, without quotes) then the scanner treats it as if no album tag is present and LMS shows the tracks under the virtual album "No Album". This is how the files are added to the libra