Re: [squid-dev] [PATCH] Do not blindly forward cache peer CONNECT responses

2015-06-19 Thread Amos Jeffries
On 20/06/2015 4:54 a.m., Alex Rousskov wrote: > Hello, > > The attached trunk patch fixes a rare but nasty problem by removing > a very old hack which shielded Squid from parsing most CONNECT responses. > > Currently, Squid blindly forwards cache peer CONNECT responses to > clients when possi

Re: [squid-dev] [PATCH] Segfault when freeing https_port clientca on reconfigure or exit

2015-06-19 Thread Alex Rousskov
On 06/18/2015 07:25 PM, Amos Jeffries wrote: > On 12/06/2015 4:56 p.m., Alex Rousskov wrote: >> Fixed segmentation fault when freeing https_port clientca on reconfigure >> or exit. >> >> AnyP::PortCfg::clientCA list was double-freed, because the SSL context >> takes ownership of the STACK_OF(X509_N

[squid-dev] [PATCH] Do not blindly forward cache peer CONNECT responses

2015-06-19 Thread Alex Rousskov
Hello, The attached trunk patch fixes a rare but nasty problem by removing a very old hack which shielded Squid from parsing most CONNECT responses. Currently, Squid blindly forwards cache peer CONNECT responses to clients when possible. This may break things if the peer responds with somethi

Re: [squid-dev] Injecting custom JavaScript

2015-06-19 Thread Alex Rousskov
On 06/18/2015 06:41 AM, James Hunter wrote: > I will investigate the ICAP and eCAP facilities if I can't get direct > access to the data from within the code. If you are creating a temporary hack, look for places where Squid passes data to the adaptation layer, such as calls to adaptVirginReplyBo

Re: [squid-dev] Injecting custom JavaScript

2015-06-19 Thread Alex Rousskov
On 06/18/2015 06:11 AM, Amos Jeffries wrote: > On 18/06/2015 11:42 p.m., James Hunter wrote: >> I've been looking to inject special JavaScript code into every HTML page >> my squid proxy receives via HTTPS connections, this is for an >> application where the users will be fully aware of the injecti

Re: [squid-dev] [PATCH] TLS: Disable client-initiated renegotiation

2015-06-19 Thread Tsantilas Christos
This patch, probably is ok as workarround, but my sense is that it is not the best method to fix it. We should spent some hours of work to check openSSL versions has the problem, and apply a better solution. On 06/19/2015 06:39 AM, Amos Jeffries wrote: Absent objections I have applied this

Re: [squid-dev] [PATCH] Add chained certificates and signing certificate to bumpAndSpliced connections

2015-06-19 Thread Tsantilas Christos
The patch should applied to trunk. On 06/19/2015 04:26 AM, Amos Jeffries wrote: On 7/06/2015 2:41 a.m., Nathan Hoad wrote: Hello, Attached is a patch making the changes recommended by Christos. I've done as described, creating a Ssl::configureUnconfiguredSslContext function, rather than making