Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-10 Thread Amos Jeffries
On 11/08/2015 3:54 a.m., Tsantilas Christos wrote: According to Squid wiki: Some actions are not possible during certain processing steps. During a given processing step, Squid ignores ssl_bump lines with impossible actions. The distributed squid.conf.documented has similar text. Current

Re: [squid-dev] [PATCH] squid SSL subsystem did not initialized correctly

2015-08-10 Thread Amos Jeffries
On 11/08/2015 4:24 a.m., Tsantilas Christos wrote: This patch looks OK Thank you. Applied as trunk rev.14217. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] Reject responses with conflicting Content-Length

2015-08-10 Thread Amos Jeffries
On 11/08/2015 9:36 a.m., Alex Rousskov wrote: On 08/07/2015 10:48 PM, Amos Jeffries wrote: On 8/08/2015 8:54 a.m., Alex Rousskov wrote: Squid trusts and forwards the largest Content-Length header. This behavior violates an RFC 7230 MUST in Section 3.3.3 item #4. It also confuses some ICAP

Re: [squid-dev] [PATCH] squid SSL subsystem did not initialized correctly

2015-08-10 Thread Tsantilas Christos
This patch looks OK On 08/10/2015 05:12 PM, Amos Jeffries wrote: On 10/08/2015 11:29 p.m., Tsantilas Christos wrote: On 08/06/2015 02:55 PM, Amos Jeffries wrote: On 6/08/2015 9:54 p.m., Tsantilas Christos wrote: Hi all, Currently SSL subsystem did not initialized correctly in squid

Re: [squid-dev] [PATCH] PayloadFormatter (was PackableStream)

2015-08-10 Thread Amos Jeffries
On 11/08/2015 2:20 a.m., Amos Jeffries wrote: Here is mk2 of the Formatter class for doing display things to CacheMgr report payloads. I have removed the ostream parts of Alex proposal. Since these formatter could create StoreEntryStream at need if they really had to and the formatting API

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-10 Thread Alex Rousskov
On 08/09/2015 01:47 AM, Amos Jeffries wrote: However the char(int_type) type constructor is necessary because this is the fundamental int_type being passed in. All the available *_castchar() operators are built to convert a 32-bit int_type value into an array of 4 bytes before dealing with the

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-10 Thread Alex Rousskov
On 08/09/2015 09:39 PM, Amos Jeffries wrote: Primarily that we can do the formatting cleanup without adding a circular dependency between libbase and libmem in the current code situation. This answer to my Why do the same change twice? question does not compute/correlate for me. I do not

[squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-10 Thread Tsantilas Christos
According to Squid wiki: Some actions are not possible during certain processing steps. During a given processing step, Squid ignores ssl_bump lines with impossible actions. The distributed squid.conf.documented has similar text. Current Squid violates the above rule. Squid considers all

[squid-dev] [RFC][CODE] RAII profiler

2015-08-10 Thread Kinkie
Hi, the attached patch implements a profiler API fashioned after the RAII pattern. It does nothing to attack the c API or the implementation, just adds on top of it a Profiler class to save the caller the hassle of having to track all exit paths from a function. As an example, it implements the

[squid-dev] [WTF] HttpHeader strangenesses

2015-08-10 Thread Kinkie
I'm going over HttpHeader to see if there's any possible improvements to be obtained by dragging it (kicking and screaming, from the look of it) into the 10's. Here's a list of weirdnesses I'm coming to find, hopefully someone has any idea of WHY they are like this, or if they can be safely be

Re: [squid-dev] [RFC][CODE] RAII profiler

2015-08-10 Thread Amos Jeffries
On 11/08/2015 10:52 a.m., Kinkie wrote: Hi, the attached patch implements a profiler API fashioned after the RAII pattern. It does nothing to attack the c API or the implementation, just adds on top of it a Profiler class to save the caller the hassle of having to track all exit paths from

Re: [squid-dev] [PATCH] squid SSL subsystem did not initialized correctly

2015-08-10 Thread Tsantilas Christos
On 08/06/2015 02:55 PM, Amos Jeffries wrote: On 6/08/2015 9:54 p.m., Tsantilas Christos wrote: Hi all, Currently SSL subsystem did not initialized correctly in squid trunk. This is because of the Security::ProxyOutgoingConfig.encryptTransport which is always false so the client SSL CTX

Re: [squid-dev] [PATCH] squid SSL subsystem did not initialized correctly

2015-08-10 Thread Amos Jeffries
On 10/08/2015 11:29 p.m., Tsantilas Christos wrote: On 08/06/2015 02:55 PM, Amos Jeffries wrote: On 6/08/2015 9:54 p.m., Tsantilas Christos wrote: Hi all, Currently SSL subsystem did not initialized correctly in squid trunk. This is because of the

[squid-dev] [PATCH] PayloadFormatter (was PackableStream)

2015-08-10 Thread Amos Jeffries
Here is mk2 of the Formatter class for doing display things to CacheMgr report payloads. I have removed the ostream parts of Alex proposal. Since these formatter could create StoreEntryStream at need if they really had to and the formatting API does not require that functionality. I've labelled