Re: [squid-dev] find-bad-changes.pl

2015-08-22 Thread Amos Jeffries
On 22/08/2015 12:44 p.m., Alex Rousskov wrote: On 08/21/2015 10:47 AM, Kinkie wrote: This is in fact what I have tried to - sometimes not to the letter, unfortunately, and I'm sorry for that. FWIW, the attached quick-and-dirty find-bad-changes.pl script detects some offending patch

Re: [squid-dev] [PATCH] Non-zeroing mempools

2015-08-22 Thread Amos Jeffries
On 22/08/2015 4:43 a.m., Kinkie wrote: On Thu, Aug 20, 2015 at 7:11 AM, Amos Jeffries squ...@treenet.co.nz wrote: On 20/08/2015 7:28 a.m., Kinkie wrote: Hi all, the attached patch (a merge request from lp:~kinkie/squid/mempools-nozero) changes MEMPROXY_CLASS so that it doesn't zero

Re: [squid-dev] [PATCH] renaming StoreEntryStream to PackableStream

2015-08-22 Thread Amos Jeffries
On 22/08/2015 5:44 a.m., Alex Rousskov wrote: On 08/21/2015 04:38 AM, Amos Jeffries wrote: So PackableStream is really just a rename of StoreEntryStream BUT with some implicit new properties from the underlying type change: * lack of Store.h dependency * ability to stream into a MemBuf if

Re: [squid-dev] find-bad-changes.pl

2015-08-22 Thread Kinkie
Hi all, I still believe we need to do these as flag-day in trunk just before branching a new version. Alex' script has lit the proverbial lightbulb. What if we were seeing this topic from the wrong end? I understand Alex' point of view that unnecessary changes make maintaining branches more

Re: [squid-dev] find-bad-changes.pl

2015-08-22 Thread Alex Rousskov
On 08/22/2015 02:03 AM, Amos Jeffries wrote: I still believe we need to do these as flag-day in trunk just before branching a new version. Just keep in mind that doing so in just one recent branch (no matter what you call it or when you do it) maximizes the overhead. Doing it in all recent