Re: [squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

On Mon, Aug 24, 2015 at 9:41 PM, Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 08/24/2015 01:21 PM, Kinkie wrote: > > > On Mon, Aug 24, 2015 at 8:37 PM, Alex Rousskov wrote: > > > > On 08/24/2015 12:08 PM, Amos Jeffries wrote: > > > On 25/08/2015 4:49 a.m., Kinkie wrote: >

[squid-dev] Jenkins build is back to normal : trunk-polygraph #851

See ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

On Wed, Aug 26, 2015 at 9:44 PM, Amos Jeffries wrote: > On 27/08/2015 6:19 a.m., Alex Rousskov wrote: > > On 08/26/2015 11:04 AM, Kinkie wrote: > > > >> v2 patch attached. > > > > FYI: If you have missed my last email on this thread, it is archived at > > http://lists.squid-cache.org/pipermail/sq

[squid-dev] [PATCH] mempools-nozero: turn StoreEntry into MEMPROXY_CLASS

Hi, this patch turns StoreEntry into MEMPROXY_CLASS, getting rid of the default constructors. In the process, it turns hash_link into a class, giving it a default constructor in order to support nonzeroing pools. The old custom allocator also gave a nonstandard chunk size; that tweak should n

Re: [squid-dev] [PATCH] coverity-fixes, part 2: SBuf hasher

Hi, the attached patch implements this suggestion renaming to SBufHashCommon_ (it seems to be a common pattern) and adding a comment. On Mon, Aug 24, 2015 at 8:51 PM, Alex Rousskov < rouss...@measurement-factory.com> wrote: > On 08/24/2015 11:13 AM, Kinkie wrote: > > this is part 2 of the cov

Re: [squid-dev] [PATCH] mempools-nozero: turn StoreEntry into MEMPROXY_CLASS

On 08/27/2015 08:58 AM, Kinkie wrote: > this patch turns StoreEntry into MEMPROXY_CLASS, getting rid of the > default constructors. > In the process, it turns hash_link into a class, giving it a default > constructor in order to support nonzeroing pools. > The old custom allocator also gave

Re: [squid-dev] [PATCH] coverity-fixes, part 2: SBuf hasher

On 08/27/2015 09:51 AM, Kinkie wrote: > Hi, > the attached patch implements this suggestion renaming to > SBufHashCommon_ (it seems to be a common pattern) and adding a comment. Thank you for changing this. This editorial change did not require a new review round IMHO. Alex. > On Mon, Aug 24,

Re: [squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

On 08/27/2015 03:51 AM, Kinkie wrote: > On 27/08/2015 6:19 a.m., Alex Rousskov wrote: > > FYI: If you have missed my last email on this thread, it is > > archived at > http://lists.squid-cache.org/pipermail/squid-dev/2015-August/003173.html I cannot tell whether you do not know t

Re: [squid-dev] [PATCH] Coverity-fixes, part 1: EnumIterator

On 08/27/2015 03:04 AM, Kinkie wrote: > > >> + * zeroth, first, second, onePastLast, fourth > > Please make onePastLast last. > > > > I'm trying to highlight the fact that > > the dereferencing will only happen on EnumType::first and > > EnumType::second. Any sugges