Re: [squid-dev] [PATCH] Remove ServerOptions "partial copy" copy constructor

2016-04-09 Thread Amos Jeffries
On 8/04/2016 2:57 a.m., Alex Rousskov wrote: > On 04/07/2016 03:22 AM, Amos Jeffries wrote: >> On 7/04/2016 6:10 p.m., Alex Rousskov wrote: >>> The attached patch removes broken and, AFAICT, unused "partial copy" >>> ServerOptions copy constructor. > > >> A (full) copy-constructor is needed o

Re: [squid-dev] [PATCH] Replace new/delete operators using modern C++ rules

2016-04-09 Thread Amos Jeffries
On 7/04/2016 7:05 p.m., Alex Rousskov wrote: > Hello, > > This change was motivated by "Mismatched free()/delete/delete[]" > errors reported by valgrind and mused about in Squid source code. > > I speculate that the old new/delete replacement code was the result of > slow accumulation of work

Re: [squid-dev] [PATCH] Do not hide important/critical messages

2016-04-09 Thread Amos Jeffries
On 29/03/2016 12:44 p.m., Alex Rousskov wrote: > Hello, > > While working on Squid bug 4465 (Header forgery detection leads to > crash), I noticed that Squid may hide important/critical debugs() > messages from the admin if those messages are assembled using code that > also uses debugs(). For

Re: [squid-dev] [PATCH] New error page token for unescaped external ACL output

2016-04-09 Thread Amos Jeffries
On 6/04/2016 11:32 a.m., Nathan Hoad wrote: > Hello, > > Attached is a patch that allows using unquoted external ACL output in > error pages. This is useful for external ACLs that return HTML and > thus shouldn't be escaped. > Applied as trunk rev.14635. Amos __

Re: [squid-dev] [PATCH] Avoid startup/shutdown crashes

2016-04-09 Thread Amos Jeffries
On 7/04/2016 6:04 p.m., Alex Rousskov wrote: > Hello, > > We spent the last few days chasing down trunk startup crashes. > Backtraces pointed to the OpenSSL context management bugs, but the > actual problem was related to the global destruction disorder in the > SBuf statistics code. The attac

[squid-dev] Build failed in Jenkins: trunk-full-matrix ยป clang,d-debian-unstable #141

2016-04-09 Thread noc
See -- [...truncated 6933 lines...] make[5]: Leaving directory '