Re: [squid-dev] [PATCH] Some failed transactions are not logged

2016-07-20 18:23 GMT+03:00 Alex Rousskov : > On 07/20/2016 09:06 AM, Amos Jeffries wrote: > > On 21/07/2016 2:44 a.m., Eduard Bagdasaryan wrote: > >> Amos, > >> just to clarify: any more touches from my side? > > > There are the bits where Alex and I agreed on a

Re: [squid-dev] Broken trunk after r14735, r14726

On 07/20/2016 10:04 AM, Christos Tsantilas wrote: > Why do we need common types for both SDKs? You have answered your own question below: > The only type needed by squid for openSSL is the "SSL *" which is stored > inside fde class. And the gnutls_session_int for gnutls. These are > should be

Re: [squid-dev] [RFC] [PREVIEW] LockingPointer round 3.

On 07/19/2016 10:45 PM, Amos Jeffries wrote: > On 19/07/2016 7:14 p.m., Amos Jeffries wrote: >> On 19/07/2016 6:58 a.m., Christos Tsantilas wrote: >>> On 07/18/2016 08:32 PM, Alex Rousskov wrote: I can only repeat my earlier suggestions to hide that dangerous constructor behind an

Re: [squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

On 07/20/2016 09:48 AM, Alex Rousskov wrote: > * Transients are needed for SMP caching to work. Correction for the first line, splitting it into two lines: - Caching is needed for collapsed forwarding to work. - Transients are needed for SMP collapsed forwarding to work. Adjusted summary, for

Re: [squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

On 07/17/2016 08:05 AM, Eduard Bagdasaryan wrote: > +/// whether this storage is capable of serving multiple workers > +virtual bool smpAware() const = 0; The description is correct, but let's also document that smpAware()ness does not say anything about non-SMP support, in case somebody

Re: [squid-dev] Broken trunk after r14735, r14726

On 07/19/2016 09:52 AM, Amos Jeffries wrote: On 18/07/2016 11:12 p.m., Christos Tsantilas wrote: On 07/16/2016 03:56 PM, Amos Jeffries wrote: On 16/07/2016 7:02 a.m., Alex Rousskov wrote: Hello, There are two more recent changes that broke trunk: * After r14735 (Replaced TidyPointer

Re: [squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

On 07/20/2016 07:21 AM, Amos Jeffries wrote: > Probably more a question for Alex; > whats the point of UsingSmp() in determining transients > initialization? I would expect collapsing to be doable in both SMP and > non-SMP modes. You are correct: Basic collapsed forwarding works in both SMP and

Re: [squid-dev] [PATCH] Some failed transactions are not logged

On 07/19/2016 10:36 PM, Amos Jeffries wrote: > On 20/07/2016 5:01 a.m., Alex Rousskov wrote: >> On 07/19/2016 08:10 AM, Amos Jeffries wrote: >>> On 20/07/2016 1:44 a.m., Eduard Bagdasaryan wrote: 2016-07-19 16:17 GMT+03:00 Amos Jeffries: > Is this patch going to include the new config

Re: [squid-dev] [PATCH] Some failed transactions are not logged

On 21/07/2016 2:44 a.m., Eduard Bagdasaryan wrote: >> 2016-07-20 7:36 GMT+03:00 Amos Jeffries: >>On 20/07/2016 5:01 a.m., Alex Rousskov wrote: >>> On 07/19/2016 08:10 AM, Amos Jeffries wrote: On 20/07/2016 1:44 a.m., Eduard Bagdasaryan wrote: > 2016-07-19 16:17 GMT+03:00 Amos Jeffries:

Re: [squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

On 21/07/2016 2:37 a.m., Eduard Bagdasaryan wrote: > 2016-07-20 16:21 GMT+03:00 Amos Jeffries: >> * smpAware() is documented as indicating whether CF is allowed. Yet the >> the new comment inside the loop of Store::Disks::smpAware() seems to be >> saying the opposite. > > As this patch says,

Re: [squid-dev] [PATCH] Some failed transactions are not logged

> 2016-07-20 7:36 GMT+03:00 Amos Jeffries : >On 20/07/2016 5:01 a.m., Alex Rousskov wrote: >> On 07/19/2016 08:10 AM, Amos Jeffries wrote: >>> On 20/07/2016 1:44 a.m., Eduard Bagdasaryan wrote: 2016-07-19 16:17 GMT+03:00 Amos Jeffries: > Is this patch going to

Re: [squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

2016-07-20 16:21 GMT+03:00 Amos Jeffries : > * smpAware() is documented as indicating whether CF is allowed. Yet the > the new comment inside the loop of Store::Disks::smpAware() seems to be > saying the opposite. As this patch says, collapsing for revalidation requests is

Re: [squid-dev] [PATCH] Fetch missing certificates

On 07/20/2016 04:42 PM, Amos Jeffries wrote: On 16/07/2016 2:08 a.m., Christos Tsantilas wrote: A new patch. It also includes the following fixes: - Sets the log_uri for ClientHttpRequest build by Downloader - Removes two XXX comments from PeerConnector class, which are not valid any

Re: [squid-dev] [PATCH] Fetch missing certificates

On 16/07/2016 2:08 a.m., Christos Tsantilas wrote: > A new patch. > > It also includes the following fixes: > - Sets the log_uri for ClientHttpRequest build by Downloader > - Removes two XXX comments from PeerConnector class, which are not > valid any more > - Make the Downloader::CbDialer

Re: [squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

On 18/07/2016 2:05 a.m., Eduard Bagdasaryan wrote: > Hello, > > 2016-07-16 0:50 GMT+03:00 Eduard Bagdasaryan: >> The attachment contains trunk patch version(for r14742) and v3.5 port > (for r14066). > > Reattached patches because of a bugfix. > Couple of things: * some of the new methods need