Re: [squid-dev] [PATCH] Faster SBuf::append

2016-11-04 Thread Alex Rousskov
On 11/04/2016 08:22 AM, Amos Jeffries wrote: > On 7/10/2016 6:20 a.m., Alex Rousskov wrote: >> On 10/06/2016 10:57 AM, Amos Jeffries wrote: >> >>> Please add a check to the unit test testSBuf::testAppendSBuf() >>> to guarantee that the (*this = S) assignment code path updates the store >>>

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-04 Thread Alex Rousskov
On 11/04/2016 01:12 AM, Kinkie wrote: > On Thu, Nov 3, 2016 at 10:55 PM, Alex Rousskov > wrote: >> On 11/03/2016 03:19 PM, Kinkie wrote: >>> On Tue, Nov 1, 2016 at 8:47 PM, Alex Rousskov wrote: On 11/01/2016 02:02 PM, Kinkie wrote: > the attached patch

Re: [squid-dev] [PATCH] Support tunneling of bumped non-HTTP traffic. Other SslBump fixes.

2016-11-04 Thread Christos Tsantilas
The SQUID-211-Skype_groups_and_msnp_bypass-t11.patch applied to trunk as r14913 The SQUID-211-FwdState_connectStart_cleanup-t1.patch patch applied as r14914 The final applied patch has one more change over the t10 patch, it merges the ConnStateData::startPeekAndSplice() and

Re: [squid-dev] [PATCH] Faster SBuf::append

2016-11-04 Thread Amos Jeffries
On 7/10/2016 6:20 a.m., Alex Rousskov wrote: > On 10/06/2016 10:57 AM, Amos Jeffries wrote: > >> Please add a check to the unit test testSBuf::testAppendSBuf() >> to guarantee that the (*this = S) assignment code path updates the store >> reference count rather than doing a bit-wise copy of the

Re: [squid-dev] [PATCH] Extend SBufContainerJoin to have prefix and suffix arguments

2016-11-04 Thread Kinkie
On Thu, Nov 3, 2016 at 10:55 PM, Alex Rousskov wrote: > On 11/03/2016 03:19 PM, Kinkie wrote: >> On Tue, Nov 1, 2016 at 8:47 PM, Alex Rousskov wrote: >>> On 11/01/2016 02:02 PM, Kinkie wrote: the attached patch extends SBufContainerJoin to have prefix and