Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread Amos Jeffries
On 16/03/2017 5:03 a.m., Adam Majer wrote: > On 03/15/2017 04:38 PM, Alex Rousskov wrote: >> On 03/15/2017 06:57 AM, Adam Majer wrote: >>> If you really want to fix this, avoid `auto` in code people actually >>> want to maintain. The only place it is actually useful is in heavily >>> templated

[squid-dev] Build failed in Jenkins: template-full-matrix ยป clang,d-ubuntu-wily #305

2017-03-15 Thread noc
See -- [...truncated 954.98 KB...] make[5]: Leaving directory

Re: [squid-dev] To make squid works in snap world.

2017-03-15 Thread Alex Rousskov
On 03/15/2017 11:03 AM, Gary Wang wrote: > On Thu, Mar 16, 2017 at 12:33 AM, Alex Rousskov wrote: >> On 03/15/2017 03:24 AM, Gary Wang wrote: >> > Regarding the confinement of usage of shared memory in snap world, >> >Please take a look at the bug >> >

Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread Adam Majer
On 03/15/2017 04:38 PM, Alex Rousskov wrote: > On 03/15/2017 06:57 AM, Adam Majer wrote: >> If you really want to fix this, avoid `auto` in code people actually >> want to maintain. The only place it is actually useful is in heavily >> templated code and that is the main reason it was introduced.

Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread Alex Rousskov
On 03/15/2017 08:17 AM, Amos Jeffries wrote: > That said, there are points in the lifecycle which are more friendly to > bg changes. The next one I expect these C++11 changes can even have a > chance is after 3.5 ceases to be a supported version. I agree, especially if "supported" includes "we

Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread Alex Rousskov
On 03/15/2017 04:43 AM, khaled belhout wrote: > I fixed the naming of the current iteration object, Thank you. FWIW, it is not necessary to add _ptr and similar suffixes to object names when the fact that it is a pointer (or a reference, or a copy) is unimportant. > limited the changes to

Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread Amos Jeffries
On 15/03/2017 11:43 p.m., khaled belhout wrote: > hello Alex > I fixed the naming of the current iteration object, limited the > changes to "src/adaptation" sub tree and replaced NULL macro by > nullptr keyword. > Hi Khaled, Thanks for the proposals and especially for identifying a tool to

Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread Adam Majer
On 03/15/2017 11:43 AM, khaled belhout wrote: > hello Alex > I fixed the naming of the current iteration object, limited the > changes to "src/adaptation" sub tree and replaced NULL macro by > nullptr keyword. I don't want to be too critical about this, but these types of changes do not add

Re: [squid-dev] Fwd: [PATCH] for loops modernization

2017-03-15 Thread khaled belhout
hello Alex I fixed the naming of the current iteration object, limited the changes to "src/adaptation" sub tree and replaced NULL macro by nullptr keyword. 2017-03-13 14:45 GMT+01:00 Alex Rousskov : > On 03/12/2017 08:42 PM, khaled belhout wrote: >> I used

Re: [squid-dev] To make squid works in snap world.

2017-03-15 Thread Gary Wang
Regarding the confinement of usage of shared memory in snap world, Please take a look at the bug https://bugs.launchpad.net/snappy/+bug/1653955 And Jamie's reply can be fuond in snapcraft maillist https://www.mail-archive.com/snapcraft@lists.snapcraft.io/ msg02465.html

Re: [squid-dev] To make squid works in snap world.

2017-03-15 Thread Eliezer Croitoru
+1 How can I reproduce he error? Is there a bug report open for this issue? Thanks, Eliezer Eliezer Croitoru Linux System Administrator Mobile: +972-5-28704261 Email: elie...@ngtech.co.il -Original Message- From: squid-dev [mailto:squid-dev-boun...@lists.squid-cache.org] On